Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1230)

Issue 869041: code review 869041: test for panic and recover (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 12 months ago by rsc
Modified:
14 years, 12 months ago
Reviewers:
CC:
r, adg, golang-dev
Visibility:
Public.

Description

test for panic and recover

Patch Set 1 #

Patch Set 2 : code review 869041: test for panic and recover #

Patch Set 3 : code review 869041: test for panic and recover #

Patch Set 4 : code review 869041: test for panic and recover #

Patch Set 5 : code review 869041: test for panic and recover #

Total comments: 1

Patch Set 6 : code review 869041: test for panic and recover #

Patch Set 7 : code review 869041: test for panic and recover #

Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -0 lines) Patch
A test/recover.go View 1 2 3 4 5 1 chunk +246 lines, -0 lines 0 comments Download
A test/recover1.go View 2 3 4 5 6 1 chunk +141 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 12 months ago (2010-03-31 08:46:31 UTC) #1
adg1
LGTM. Fun bit of code =) On 31 March 2010 19:46, <rsc@golang.org> wrote: > Reviewers: ...
14 years, 12 months ago (2010-03-31 11:15:48 UTC) #2
r
LGTM http://codereview.appspot.com/869041/diff/11001/12001 File test/recover.go (right): http://codereview.appspot.com/869041/diff/11001/12001#newcode123 test/recover.go:123: defer func() { i'd like another version where ...
14 years, 12 months ago (2010-03-31 16:01:31 UTC) #3
rsc
done
14 years, 12 months ago (2010-03-31 17:08:18 UTC) #4
rsc
14 years, 12 months ago (2010-03-31 18:47:13 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=5fbc29d68759 ***

test for panic and recover

R=r, adg
CC=golang-dev
http://codereview.appspot.com/869041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b