code review 86770043: net/http/httptest: add test for issue 7264

net/http/httptest: add test for issue 7264
The test fails now with -race, so it's disabled.
The intention is that the fix for issue 7264
will also modify this test the same way and enable it.
Reporduce with 'go test -race -issue7264 -cpu=4'.
Update issue 7264

[dvyukov, 2014-04-11 08:37:28]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[bradfitz, 2014-04-11 08:46:15]

LGTM
 On Apr 11, 2014 1:37 AM, <dvyukov@google.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://dvyukov%40google.com@code.google.com/p/go/
>
>
> Description:
> net/http/httptest: add test for issue 7264
> The test fails now with -race, so it's disabled.
> The intention is that the fix for issue 7264
> will also modify this test the same way and enable it.
> Reporduce with 'go test -race -issue7264 -cpu=4'.
> Update issue 7264
>
> Please review this at https://codereview.appspot.com/86770043/
>
> Affected files (+25, -0 lines):
>   M src/pkg/net/http/httptest/server_test.go
>
>
> Index: src/pkg/net/http/httptest/server_test.go
> ===================================================================
> --- a/src/pkg/net/http/httptest/server_test.go
> +++ b/src/pkg/net/http/httptest/server_test.go
> @@ -5,9 +5,11 @@
>  package httptest
>
>  import (
> +       "flag"
>         "io/ioutil"
>         "net/http"
>         "testing"
> +       "time"
>  )
>
>  func TestServer(t *testing.T) {
> @@ -27,3 +29,26 @@
>                 t.Errorf("got %q, want hello", string(got))
>         }
>  }
> +
> +var testIssue7264 = flag.Bool("issue7264", false, "enable failing test
> for issue 7264")
> +
> +func TestIssue7264(t *testing.T) {
> +       if !*testIssue7264 {
> +               t.Skip("skipping failing test for issue 7264")
> +       }
> +       for i := 0; i < 1000; i++ {
> +               func() {
> +                       ts := NewServer(http.HandlerFunc(func(w
> http.ResponseWriter, r *http.Request) {}))
> +                       defer ts.Close()
> +                       tr := &http.Transport{
> +                               ResponseHeaderTimeout: time.Nanosecond,
> +                       }
> +                       defer tr.CloseIdleConnections()
> +                       c := &http.Client{Transport: tr}
> +                       res, err := c.Get(ts.URL)
> +                       if err == nil {
> +                               res.Body.Close()
> +                       }
> +               }()
> +       }
> +}
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[dvyukov, 2014-04-11 09:01:13]

*** Submitted as https://code.google.com/p/go/source/detail?r=22f0f37278ad ***

net/http/httptest: add test for issue 7264
The test fails now with -race, so it's disabled.
The intention is that the fix for issue 7264
will also modify this test the same way and enable it.
Reporduce with 'go test -race -issue7264 -cpu=4'.
Update issue 7264

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/86770043

[gobot, 2014-04-11 09:18:52]

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/3f2f16d46523467f9f908a3cc473f91c80de7509