code review 86730043: expvar: fix map key output

expvar: fix map key output

To create a valid JSON string, "%s" is not enough.
Fixes issue 7761.

[ruiu, 2014-04-11 03:48:29]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-04-11 04:03:59]

I don't think %q is quite right for JSON either, though.

[ruiu, 2014-04-11 04:07:09]

Maybe, but it's what this package is currently doing to quote a string.
Look at the Fprintf in expvarHandler.

On Fri, Apr 11, 2014 at 1:03 PM, <bradfitz@golang.org> wrote:

> I don't think %q is quite right for JSON either, though.
>
>
> https://codereview.appspot.com/86730043/
>

[bradfitz, 2014-04-11 04:13:28]

LGTM

Okay, good enough.

Maybe later this package should depend on json and use it to encode a
string.



On Thu, Apr 10, 2014 at 9:06 PM, Rui Ueyama <ruiu@google.com> wrote:

> Maybe, but it's what this package is currently doing to quote a string.
> Look at the Fprintf in expvarHandler.
>
> On Fri, Apr 11, 2014 at 1:03 PM, <bradfitz@golang.org> wrote:
>
>> I don't think %q is quite right for JSON either, though.
>>
>>
>> https://codereview.appspot.com/86730043/
>>
>
>

[bradfitz, 2014-04-11 04:14:09]

*** Submitted as https://code.google.com/p/go/source/detail?r=ec9c977359c1 ***

expvar: fix map key output

To create a valid JSON string, "%s" is not enough.
Fixes issue 7761.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/86730043

Committer: Brad Fitzpatrick <bradfitz@golang.org>