code review 867044: io/ioutil: fix bug in ReadFile when Open succeeds but S...

io/ioutil: fix bug in ReadFile when Open succeeds but Stat fails

[rsc, 2010-04-06 05:13:48]

Hello gri (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[gri, 2010-04-06 06:35:20]

LGTM

On Mon, Apr 5, 2010 at 10:13 PM, <rsc@golang.org> wrote:

> Reviewers: gri,
>
> Message:
> Hello gri (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> io/ioutil: fix bug in ReadFile when Open succeeds but Stat fails
>
> Please review this at http://codereview.appspot.com/867044/show
>
> Affected files:
>  M src/pkg/io/ioutil/ioutil.go
>
>
> Index: src/pkg/io/ioutil/ioutil.go
> ===================================================================
> --- a/src/pkg/io/ioutil/ioutil.go
> +++ b/src/pkg/io/ioutil/ioutil.go
> @@ -31,7 +31,7 @@
>        // read, so let's try it but be prepared for the answer to be wrong.
>        dir, err := f.Stat()
>        var n uint64
> -       if err != nil && dir.Size < 2e9 { // Don't preallocate a huge
> buffer, just in case.
> +       if err == nil && dir.Size < 2e9 { // Don't preallocate a huge
> buffer, just in case.
>                n = dir.Size
>        }
>        // Add a little extra in case Size is zero, and to avoid another
> allocation after
>
>
>

[rsc, 2010-04-06 06:36:54]

*** Submitted as http://code.google.com/p/go/source/detail?r=ad786f855072 ***

io/ioutil: fix bug in ReadFile when Open succeeds but Stat fails

R=gri
CC=golang-dev
http://codereview.appspot.com/867044