code review 8653047: encoding/xml: allow attributes stored in pointers to be...

encoding/xml: allow attributes stored in pointers to be marshaled.

Fixes issue 5334.

[deemok, 2013-04-23 04:10:10]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[deemok, 2013-04-23 19:10:18]

Sorry, just found out that I made a mistake and will resubmit the patch!
Please ignore the first patch set.

[deemok, 2013-04-23 19:24:43]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[dave_cheney.net, 2013-06-01 07:07:12]

On 2013/04/23 19:24:43, deemok wrote:
> Hello mailto:golang-dev@googlegroups.com (cc:
mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

ping

[rsc, 2013-06-03 20:08:56]

https://codereview.appspot.com/8653047/diff/17001/src/pkg/encoding/xml/marsha...
File src/pkg/encoding/xml/marshal.go (right):

https://codereview.appspot.com/8653047/diff/17001/src/pkg/encoding/xml/marsha...
src/pkg/encoding/xml/marshal.go:288: // handle pointer values by following the
pointer
// Pointer is known to be non-nil because we called isEmptyValue above.

can delete the rest of the comment.

[deemok, 2013-06-04 00:40:24]

Hello golang-dev@googlegroups.com, dave@cheney.net, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[deemok, 2013-06-04 00:51:52]

Hello golang-dev@googlegroups.com, dave@cheney.net, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2013-08-08 12:03:51]

LGTM

Apologies for dropping this on the floor.

[rsc, 2013-08-08 12:06:42]

You don't appear to have completed a CLA
(golang.org/doc/contribute.html#copyright).

Since the change here is so tiny and since it's been an embarrassingly long
time, I will roll it into my work on adding Marshaler support (CL 12603044).
Alternately, if you do want the CL submitted under your name, complete a CLA and
reply here and I'll submit it separately.

Thanks, and apologies again.

[deemok, 2013-08-08 13:26:55]

Hi, Russ.
No worries.
I've completed the CLA.
Sorry I've not read the contributor's manual thoroughly enough.

dmitri.

[bradfitz, 2013-08-08 17:41:08]

*** Submitted as https://code.google.com/p/go/source/detail?r=084c06f07a87 ***

encoding/xml: allow attributes stored in pointers to be marshaled.

Fixes issue 5334.

R=golang-dev, dave, rsc
CC=golang-dev
https://codereview.appspot.com/8653047

Committer: Brad Fitzpatrick <bradfitz@golang.org>