Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(680)

Issue 8649043: code review 8649043: spec: add another sentence about BOMs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by r
Modified:
11 years ago
Reviewers:
CC:
golang-dev, dsymonds, gri
Visibility:
Public.

Description

spec: add another sentence about BOMs Although one may argue that they should be legal, gc (at least) disallows byte order marks that are not the first code point in the file. Added a sentence to the "Implementation restriction" clause in the "Source code representation" section to document this better. Lifting this restriction (again - the rule has changed at least twice already) would not break any existing programs, should we later decide yet again to fiddle the rules about these little fly specks.

Patch Set 1 #

Patch Set 2 : diff -r b3017cc3e17b https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M doc/go_spec.html View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years ago (2013-04-11 02:30:35 UTC) #1
dsymonds
LGTM
11 years ago (2013-04-11 03:13:17 UTC) #2
gri
LGTM
11 years ago (2013-04-11 16:00:41 UTC) #3
r
11 years ago (2013-04-11 18:33:34 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=b3399da3d34a ***

spec: add another sentence about BOMs
Although one may argue that they should be legal, gc (at least)
disallows byte order marks that are not the first code point
in the file. Added a sentence to the "Implementation restriction"
clause in the "Source code representation" section to document
this better.

Lifting this restriction (again - the rule has changed at least
twice already) would not break any existing programs, should
we later decide yet again to fiddle the rules about these little
fly specks.

R=golang-dev, dsymonds, gri
CC=golang-dev
https://codereview.appspot.com/8649043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b