code review 86220044: bufio: fix potential endless loop in ReadByte

bufio: fix potential endless loop in ReadByte

Fixes issue 7745.

[gri, 2014-04-09 22:50:17]

Hello r@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-04-09 22:52:43]

LGTM

https://codereview.appspot.com/86220044/diff/40001/src/pkg/bufio/bufio_test.go
File src/pkg/bufio/bufio_test.go (right):

https://codereview.appspot.com/86220044/diff/40001/src/pkg/bufio/bufio_test.g...
src/pkg/bufio/bufio_test.go:201: case <-time.After(10 * time.Millisecond):
increase this. too short for some weakling builders. 

1 second seems both short and long enough.

[r, 2014-04-10 00:04:38]

LGTM

[gri, 2014-04-10 00:52:37]

https://codereview.appspot.com/86220044/diff/40001/src/pkg/bufio/bufio_test.go
File src/pkg/bufio/bufio_test.go (right):

https://codereview.appspot.com/86220044/diff/40001/src/pkg/bufio/bufio_test.g...
src/pkg/bufio/bufio_test.go:201: case <-time.After(10 * time.Millisecond):
On 2014/04/09 22:52:44, bradfitz wrote:
> increase this. too short for some weakling builders. 
> 
> 1 second seems both short and long enough.

Done.

[gri, 2014-04-10 00:53:18]

*** Submitted as https://code.google.com/p/go/source/detail?r=41388e58be65 ***

bufio: fix potential endless loop in ReadByte

Fixes issue 7745.

LGTM=bradfitz, r
R=r, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/86220044

[gobot, 2014-04-10 00:56:38]

This CL appears to have broken the freebsd-amd64 builder.
See http://build.golang.org/log/144f21cfbecde22a08712f08ea88daeec0ce3804

[r, 2014-04-10 00:58:44]

I think this is a real failure.

-rob

[dave_cheney.net, 2014-04-10 01:01:35]

I agree.

On Thu, Apr 10, 2014 at 10:58 AM, Rob Pike <r@golang.org> wrote:
> I think this is a real failure.
>
> -rob
>
> --
> You received this message because you are subscribed to the Google Groups
"golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[gri, 2014-04-10 01:08:05]

See new CL I just sent.
- gri


On Wed, Apr 9, 2014 at 6:01 PM, Dave Cheney <dave@cheney.net> wrote:

> I agree.
>
> On Thu, Apr 10, 2014 at 10:58 AM, Rob Pike <r@golang.org> wrote:
> > I think this is a real failure.
> >
> > -rob
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "golang-codereviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to golang-codereviews+unsubscribe@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
>