Issue 86180043: code review 86180043: bufio: fix UnreadByte

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 86180043: code review 86180043: bufio: fix UnreadByte (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by gri

Modified:
10 years, 1 month ago

Reviewers:
r

CC:
r, golang-codereviews

Visibility:
Public.

Description

bufio: fix UnreadByte Also: - fix error messages in tests - make tests more symmetric Fixes issue 7607.

Patch Set 1 #

Patch Set 2 : diff -r 29a6a4ac1164 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 29a6a4ac1164 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 29a6a4ac1164 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 29a6a4ac1164 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 98e63c935796 https://code.google.com/p/go/ #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -30 lines)			Patch
	M	src/pkg/bufio/bufio.go	View	1 2	3 chunks	+12 lines, -12 lines	0 comments	Download
	M	src/pkg/bufio/bufio_test.go	View	1 2 3 4	1 chunk	+46 lines, -18 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello r@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 1 month ago (2014-04-09 20:55:13 UTC) #1

Someone recently blogged about how clunky the bufio code is. His points were largely off ...

10 years, 1 month ago (2014-04-09 21:19:23 UTC) #3

gri

10 years, 1 month ago (2014-04-09 21:19:27 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=08be3027bc9f ***

bufio: fix UnreadByte

Also:
- fix error messages in tests
- make tests more symmetric

Fixes issue 7607.

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/86180043

Expand All Messages | Collapse All Messages