code review 8603045: go.talks/present: allow playground output panel resizing

go.talks/present: allow playground output panel resizing

Fixes issue 5078.

[kortschak, 2013-04-10 02:48:28]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.talks

[kortschak, 2013-04-17 07:09:21]

<ping>

[gobot, 2013-04-18 02:52:18]

R=adg (assigned by dsymonds)

[kortschak, 2013-04-19 03:53:52]

https://codereview.appspot.com/8603045/diff/16001/present/js/play.js
File present/js/play.js (right):

https://codereview.appspot.com/8603045/diff/16001/present/js/play.js#newcode38
present/js/play.js:38: $(output).resizable({handles: "n,w,nw", minHeight: 27,
minWidth: 135, maxHeight: 608, maxWidth: 990});
maxWidth would be 998 for symmetry, but then we get collision with
#prev-slide-area. If #{next,prev}-slide-area can be shrunk we can make the
output symmetrical. Probably not worth it.

[adg, 2013-05-22 00:09:49]

Looks good

https://codereview.appspot.com/8603045/diff/16001/present/js/play.js
File present/js/play.js (right):

https://codereview.appspot.com/8603045/diff/16001/present/js/play.js#newcode38
present/js/play.js:38: $(output).resizable({handles: "n,w,nw", minHeight: 27,
minWidth: 135, maxHeight: 608, maxWidth: 990});
Can you expand this so each field is on a separate line?

[kortschak, 2013-05-22 00:23:56]

PTAL

https://codereview.appspot.com/8603045/diff/16001/present/js/play.js
File present/js/play.js (right):

https://codereview.appspot.com/8603045/diff/16001/present/js/play.js#newcode38
present/js/play.js:38: $(output).resizable({handles: "n,w,nw", minHeight: 27,
minWidth: 135, maxHeight: 608, maxWidth: 990});
On 2013/05/22 00:09:49, adg wrote:
> Can you expand this so each field is on a separate line?

Done.

[adg, 2013-05-22 00:28:00]

*** Submitted as
https://code.google.com/p/go/source/detail?r=b21fcde83af7&repo=talks ***

go.talks/present: allow playground output panel resizing

Fixes issue 5078.

R=adg
CC=gobot, golang-dev
https://codereview.appspot.com/8603045

Committer: Andrew Gerrand <adg@golang.org>

[adg, 2013-05-22 00:28:10]

LGTM

Thanks. Sorry for taking so long to complete this review.