Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3439)

Issue 85760043: code review 85760043: doc: add a couple net/http go1.3 items (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 12 months ago by bradfitz
Modified:
10 years, 12 months ago
Reviewers:
r, Dmitri Melnikov
CC:
r, golang-codereviews
Visibility:
Public.

Description

doc: add a couple net/http go1.3 items

Patch Set 1 #

Patch Set 2 : diff -r ef29a98109b3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ef29a98109b3 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r b4c775ba49be https://go.googlecode.com/hg/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M doc/go1.3.html View 1 2 3 1 chunk +11 lines, -2 lines 1 comment Download

Messages

Total messages: 6
bradfitz
Hello r@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 12 months ago (2014-04-09 00:18:33 UTC) #1
r
LGTM https://codereview.appspot.com/85760043/diff/40001/doc/go1.3.html File doc/go1.3.html (right): https://codereview.appspot.com/85760043/diff/40001/doc/go1.3.html#newcode237 doc/go1.3.html:237: Previously all errors went to stderr.</li> LGTM but ...
10 years, 12 months ago (2014-04-09 00:25:35 UTC) #2
r
https://codereview.appspot.com/85760043/diff/40001/doc/go1.3.html File doc/go1.3.html (right): https://codereview.appspot.com/85760043/diff/40001/doc/go1.3.html#newcode237 doc/go1.3.html:237: Previously all errors went to stderr.</li> maybe s/Previously/The default ...
10 years, 12 months ago (2014-04-09 00:26:18 UTC) #3
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=5b387802e010 *** doc: add a couple net/http go1.3 items LGTM=r R=r CC=golang-codereviews ...
10 years, 12 months ago (2014-04-09 02:46:05 UTC) #4
Dmitri Melnikov
https://codereview.appspot.com/85760043/diff/60001/doc/go1.3.html File doc/go1.3.html (right): https://codereview.appspot.com/85760043/diff/60001/doc/go1.3.html#newcode232 doc/go1.3.html:232: the properties of a TLS connection used to make ...
10 years, 12 months ago (2014-04-10 13:27:18 UTC) #5
bradfitz
10 years, 12 months ago (2014-04-10 17:16:06 UTC) #6
Thanks, fixed in pending CL.



On Thu, Apr 10, 2014 at 6:27 AM, <dmitri.m@gmail.com> wrote:

>
> https://codereview.appspot.com/85760043/diff/60001/doc/go1.3.html
> File doc/go1.3.html (right):
>
> https://codereview.appspot.com/85760043/diff/60001/doc/
> go1.3.html#newcode232
> doc/go1.3.html:232: the properties of a TLS connection used to make a
>
> client request in the new
> "... the the properties ..."
>
> https://codereview.appspot.com/85760043/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b