Issue 85740046: code review 85740046: net/http: fix up Response.Write edge cases

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 85740046: code review 85740046: net/http: fix up Response.Write edge cases (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by bradfitz

Modified:
10 years ago

Reviewers:
adg

CC:
golang-codereviews, adg, dsymonds, rsc

Visibility:
Public.

Description

net/http: fix up Response.Write edge cases The Go HTTP server doesn't use Response.Write, but others do, so make it correct. Add a bunch more tests. This bug is almost a year old. :/ Fixes Issue 5381

Patch Set 1 #

Patch Set 2 : diff -r 6cec80ff723b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6cec80ff723b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c8a9e0fd84f7 https://go.googlecode.com/hg/ #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -5 lines)			Patch
M	src/pkg/net/http/response.go	View	1	4 chunks	+47 lines, -4 lines	0 comments	Download
M	src/pkg/net/http/response_test.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/pkg/net/http/responsewrite_test.go	View	1	2 chunks	+101 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-codereviews@googlegroups.com (cc: adg@golang.org, dsymonds@golang.org, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/

10 years ago (2014-04-10 23:25:16 UTC) #1

bradfitz

10 years ago (2014-04-11 00:12:37 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=b2ebbbcfc615 ***

net/http: fix up Response.Write edge cases

The Go HTTP server doesn't use Response.Write, but others do,
so make it correct. Add a bunch more tests.

This bug is almost a year old. :/

Fixes Issue 5381

LGTM=adg
R=golang-codereviews, adg
CC=dsymonds, golang-codereviews, rsc
https://codereview.appspot.com/85740046

Expand All Messages | Collapse All Messages