Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(49)

Issue 85720045: code review 85720045: ogle/program/server: discover architecture by reading o... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by r
Modified:
9 years, 11 months ago
Reviewers:
nigeltao
CC:
nigeltao
Visibility:
Public.

Description

ogle/program/server: discover architecture by reading object file

Patch Set 1 #

Patch Set 2 : diff -r 82ff9d268a24 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -6 lines) Patch
M program/server/server.go View 1 2 chunks +32 lines, -6 lines 0 comments Download

Messages

Total messages: 3
r
Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle
9 years, 11 months ago (2014-04-09 05:52:23 UTC) #1
nigeltao
LGTM. I'm not sure if this handles e.g. NaCl, which IIUC has the amd64 instruction ...
9 years, 11 months ago (2014-04-09 05:55:07 UTC) #2
r
9 years, 11 months ago (2014-04-09 05:59:35 UTC) #3
*** Submitted as https://code.google.com/p/ogle/source/detail?r=f3347973b1cb ***

ogle/program/server: discover architecture by reading object file

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/85720045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b