code review 855043: go spec: correct clarification of type declaration

go spec: correct clarification of type declaration

[gri, 2010-04-01 05:01:57]

Hello rsc, r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-04-01 05:47:55]

http://codereview.appspot.com/855043/diff/2001/3001
File doc/go_spec.html (right):

http://codereview.appspot.com/855043/diff/2001/3001#newcode1740
doc/go_spec.html:1740: of elements of a composite type or of an interface type
is not changed:
s/or of an interface type //

This sentence changed in the last review too.
I think this sentence is talking about embedded struct fields
not losing their methods; interfaces don't have elements
to talk about.

[gri, 2010-04-01 06:25:21]

PTAL

http://codereview.appspot.com/855043/diff/2001/3001
File doc/go_spec.html (right):

http://codereview.appspot.com/855043/diff/2001/3001#newcode1740
doc/go_spec.html:1740: of elements of a composite type or of an interface type
is not changed:
On 2010/04/01 05:47:55, rsc1 wrote:
> s/or of an interface type //
> 
> This sentence changed in the last review too.

Yes, intentionally (and before the "identity crisis" :-)

> I think this sentence is talking about embedded struct fields
> not losing their methods; interfaces don't have elements
> to talk about.

Yes, but interfaces don't loose their method sets either.

Strictly speaking the very first sentence says it all (and at some point this
was all there was). We added the 2nd sentence to emphasize the subtlety about
element method sets; I think a similar emphasis is warranted for interface
method sets.

Slightly rephrased.

[rsc, 2010-04-01 07:24:49]

LGTM but wait for r.

i get it now - much clearer.

[r2, 2010-04-01 19:22:01]

LGTM

On Apr 1, 2010, at 12:24 AM, Russ Cox wrote:

> LGTM but wait for r.
> 
> i get it now - much clearer.

[gri, 2010-04-01 19:48:37]

*** Submitted as http://code.google.com/p/go/source/detail?r=bb400b5e55cb ***

go spec: correct clarification of type declaration

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/855043

Committer: Robert Griesemer <gri@golang.org>