Issue 8504044: code review 8504044: archive/zip: handle trailing data after the end of dire...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8504044: code review 8504044: archive/zip: handle trailing data after the end of dire... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by adg

Modified:
11 years ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

archive/zip: handle trailing data after the end of directory header The spec doesn't explicitly say that trailing data is okay, but a lot of people do this and most unzippers will handle it just fine. In any case, this makes the package more useful, and led me to make the directory parsing code marginally more robust. Fixes issue 5228.

Patch Set 1 #

Patch Set 2 : diff -r b7fb7733b29b https://code.google.com/p/go #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -2 lines)			Patch
M	src/pkg/archive/zip/reader.go	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	src/pkg/archive/zip/reader_test.go	View	2 chunks	+19 lines, -1 line	0 comments	Download
A	src/pkg/archive/zip/testdata/test-trailing-junk.zip	View	Binary file		0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years ago (2013-04-08 05:21:35 UTC) #1

adg

11 years ago (2013-04-08 05:38:12 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=a32218df2dff ***

archive/zip: handle trailing data after the end of directory header

The spec doesn't explicitly say that trailing data is okay, but a lot
of people do this and most unzippers will handle it just fine. In any
case, this makes the package more useful, and led me to make the
directory parsing code marginally more robust.

Fixes issue 5228.

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/8504044

Expand All Messages | Collapse All Messages