Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1062)

Issue 850041: code review 850041: single argument panic (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 12 months ago by rsc
Modified:
14 years, 12 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

single argument panic note that sortmain.go has been run through hg gofmt; only the formatting of the day initializers changed. i'm happy to revert that formatting if you'd prefer. stop on error in doc/progs/run

Patch Set 1 #

Patch Set 2 : code review 850041: single argument panic #

Total comments: 2

Patch Set 3 : code review 850041: single argument panic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+929 lines, -813 lines) Patch
M doc/progs/run View 1 chunk +2 lines, -0 lines 0 comments Download
M doc/progs/sortmain.go View 1 3 chunks +10 lines, -10 lines 0 comments Download
M src/cmd/cgo/ast.go View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/godoc/index.go View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/goinstall/download.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/bufio/bufio.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/bytes/bytes_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M src/pkg/crypto/block/cmac.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/eval/eval_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/eval/expr.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/exp/eval/expr1.go View 1 7 chunks +29 lines, -33 lines 0 comments Download
M src/pkg/exp/eval/gen.go View 3 chunks +4 lines, -4 lines 0 comments Download
M src/pkg/exp/eval/type.go View 5 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/exp/ogle/rvalue.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/exp/ogle/vars.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/ast/walk.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/parser/parser.go View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/pkg/go/printer/printer.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/gob/decode.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/http/lex.go View 1 chunk +2 lines, -6 lines 0 comments Download
M src/pkg/net/fd.go View 2 chunks +2 lines, -6 lines 0 comments Download
M src/pkg/net/unixsock.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/reflect/value.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/strconv/ftoa_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M src/pkg/template/template.go View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/time/time.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/websocket/server.go View 2 chunks +2 lines, -2 lines 0 comments Download
M test/235.go View 2 chunks +27 lines, -22 lines 0 comments Download
M test/chan/doubleselect.go View 1 chunk +2 lines, -1 line 0 comments Download
M test/chan/nonblock.go View 1 chunk +142 lines, -76 lines 0 comments Download
M test/chan/sieve1.go View 1 chunk +17 lines, -14 lines 0 comments Download
M test/chan/sieve2.go View 1 chunk +2 lines, -1 line 0 comments Download
M test/cmp1.go View 1 chunk +2 lines, -1 line 0 comments Download
M test/fixedbugs/bug082.go View 1 chunk +9 lines, -6 lines 0 comments Download
M test/fixedbugs/bug084.go View 1 chunk +9 lines, -6 lines 0 comments Download
M test/fixedbugs/bug097.go View 2 chunks +15 lines, -9 lines 0 comments Download
M test/fixedbugs/bug110.go View 1 chunk +2 lines, -1 line 0 comments Download
M test/fixedbugs/bug117.go View 2 chunks +8 lines, -4 lines 0 comments Download
M test/fixedbugs/bug168.go View 1 chunk +7 lines, -6 lines 0 comments Download
M test/fixedbugs/bug194.go View 1 chunk +14 lines, -11 lines 0 comments Download
M test/fixedbugs/bug221.go View 2 chunks +13 lines, -9 lines 0 comments Download
M test/fixedbugs/bug227.go View 2 chunks +8 lines, -6 lines 0 comments Download
M test/fixedbugs/bug234.go View 1 chunk +4 lines, -2 lines 0 comments Download
M test/fixedbugs/bug244.go View 1 chunk +2 lines, -1 line 0 comments Download
M test/fixedbugs/bug253.go View 1 chunk +3 lines, -2 lines 0 comments Download
M test/fixedbugs/bug262.go View 1 chunk +4 lines, -2 lines 0 comments Download
M test/func5.go View 3 chunks +36 lines, -36 lines 0 comments Download
M test/golden.out View 1 chunk +1 line, -1 line 0 comments Download
M test/interface/convert.go View 2 chunks +62 lines, -54 lines 0 comments Download
M test/interface/receiver.go View 1 chunk +2 lines, -1 line 0 comments Download
M test/ken/array.go View 1 chunk +75 lines, -86 lines 0 comments Download
M test/ken/chan.go View 2 chunks +171 lines, -171 lines 0 comments Download
M test/ken/string.go View 1 chunk +54 lines, -48 lines 0 comments Download
M test/mallocfin.go View 1 chunk +3 lines, -2 lines 0 comments Download
M test/mallocrep.go View 1 chunk +2 lines, -1 line 0 comments Download
M test/peano.go View 4 chunks +38 lines, -38 lines 0 comments Download
M test/simassign.go View 1 chunk +42 lines, -44 lines 0 comments Download
M test/typeswitch1.go View 1 chunk +34 lines, -35 lines 0 comments Download
M test/varinit.go View 1 chunk +16 lines, -7 lines 0 comments Download
M test/vectors.go View 2 chunks +16 lines, -13 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 12 months ago (2010-03-30 08:39:10 UTC) #1
r
LGTM http://codereview.appspot.com/850041/diff/2001/3025 File src/pkg/template/template.go (right): http://codereview.appspot.com/850041/diff/2001/3025#newcode986 src/pkg/template/template.go:986: panic(err) these panics can happen. i'd prefer panic("template.MustParse ...
14 years, 12 months ago (2010-03-30 17:01:24 UTC) #2
rsc
14 years, 12 months ago (2010-03-30 17:35:01 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=731aeabbce55 ***

single argument panic

note that sortmain.go has been run through hg gofmt;
only the formatting of the day initializers changed.
i'm happy to revert that formatting if you'd prefer.

stop on error in doc/progs/run

R=r
CC=golang-dev
http://codereview.appspot.com/850041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b