Issue 84920043: code review 84920043: build: remove depdenency on GNU make

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 84920043: code review 84920043: build: remove depdenency on GNU make (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by adg

Modified:
10 years, 11 months ago

Reviewers:
gobot, bradfitz

CC:
bradfitz, golang-codereviews

Visibility:
Public.

Patch Set 2 : diff -r 519230b4d06a https://code.google.com/p/go #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -11 lines)			Patch
R	doc/articles/wiki/Makefile	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	doc/articles/wiki/test.bash	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/run.bash	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello bradfitz (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 11 months ago (2014-04-07 01:28:31 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=7be69c14d0f3 *** build: remove depdenency on GNU make LGTM=bradfitz R=bradfitz CC=golang-codereviews https://codereview.appspot.com/84920043

10 years, 11 months ago (2014-04-07 01:34:38 UTC) #3

gobot

This CL appears to have broken the openbsd-amd64-rootbsd builder. See http://build.golang.org/log/b3f8aa50baffa324a92edd5774f658a8eb07da92

10 years, 11 months ago (2014-04-07 01:49:35 UTC) #4

adg

10 years, 11 months ago (2014-04-07 01:54:32 UTC) #5

On 7 April 2014 11:49, <gobot@golang.org> wrote:

> This CL appears to have broken the openbsd-amd64-rootbsd builder.
> See http://build.golang.org/log/b3f8aa50baffa324a92edd5774f658a8eb07da92
>

Nope

Expand All Messages | Collapse All Messages