Issue 848042: code review 848042: godoc: support for title and subtitle headers when serv...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 848042: code review 848042: godoc: support for title and subtitle headers when serv... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by gri

Modified:
14 years ago

Reviewers:

CC:
rsc, golang-dev, r

Visibility:
Public.

Description

godoc: support for title and subtitle headers when serving .html docs and use it to show version (date) of go spec Fixes issue 68.

Patch Set 1 #

Patch Set 2 : code review 848042: godoc: support for title and subtitle headers when serv... #

Patch Set 3 : code review 848042: godoc: support for title and subtitle headers when serv... #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -19 lines)			Patch
M	doc/go_spec.html	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	doc/style.css	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/godoc/godoc.html	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	src/cmd/godoc/godoc.go	View	10 chunks	+26 lines, -16 lines	0 comments	Download
M	src/cmd/godoc/main.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com, r), I'd like you to review this change.

14 years ago (2010-03-30 23:48:41 UTC) #1

rsc1

I thought the plan was to use runtime.Version() to avoid needing to edit the date.

14 years ago (2010-03-31 00:29:05 UTC) #2

gri

runtime.Version is already shown, but it changes much more often than the spec. It seems ...

14 years ago (2010-03-31 00:33:12 UTC) #3

gri

14 years ago (2010-03-31 00:37:44 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=0bf8bf7d8266 ***

godoc: support for title and subtitle headers when serving .html docs
and use it to show version (date) of go spec

Fixes issue 68.

R=rsc
CC=golang-dev, r
http://codereview.appspot.com/848042

Expand All Messages | Collapse All Messages