Issue 84800044: code review 84800044: net: move error messages related to OpError into net.go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 84800044: code review 84800044: net: move error messages related to OpError into net.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by mikio

Modified:
10 years ago

Reviewers:
iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

net: move error messages related to OpError into net.go Also makes ErrWriteToConnected more appropriate; it's used not only UDPConn operations but UnixConn operations. Update issue 4856

Patch Set 1 #

Patch Set 2 : diff -r 6063871258af https://code.google.com/p/go #

Patch Set 3 : diff -r 6063871258af https://code.google.com/p/go #

Patch Set 4 : diff -r e8e6479619b5 https://code.google.com/p/go #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
	M	src/pkg/net/net.go	View	1	2 chunks	+10 lines, -5 lines	0 comments	Download
	M	src/pkg/net/udpsock.go	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years ago (2014-04-07 05:10:57 UTC) #1

iant

LGTM I suppose this is OK but remember that we are in a code freeze. ...

10 years ago (2014-04-07 15:46:06 UTC) #2

mikio

10 years ago (2014-04-07 21:14:57 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=9863d3ea9f01 ***

net: move error messages related to OpError into net.go

Also makes ErrWriteToConnected more appropriate; it's used
not only UDPConn operations but UnixConn operations.

Update issue 4856

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/84800044

Expand All Messages | Collapse All Messages