Issue 84660046: code review 84660046: net: remove "net:" prefix from error messages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 84660046: code review 84660046: net: remove "net:" prefix from error messages (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by mikio

Modified:
10 years ago

Reviewers:
gobot, iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

net: remove "net:" prefix from error messages The prefix was not uniformly applied and is probably better left off for using with OpError. Update issue 4856

Patch Set 1 #

Patch Set 2 : diff -r 6063871258af https://code.google.com/p/go #

Patch Set 3 : diff -r 6063871258af https://code.google.com/p/go #

Patch Set 4 : diff -r 065aeab132e1 https://code.google.com/p/go #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
M	src/pkg/net/interface.go	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/pkg/net/ipsock_plan9.go	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/net/lookup_plan9.go	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mikio

Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years ago (2014-04-07 05:10:29 UTC) #1

mikio

*** Submitted as https://code.google.com/p/go/source/detail?r=e8e6479619b5 *** net: remove "net:" prefix from error messages The prefix was ...

10 years ago (2014-04-07 21:14:30 UTC) #3

gobot

10 years ago (2014-04-07 21:41:38 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the linux-386 builder.
See http://build.golang.org/log/4c93efaf93786da4a9e9f951f3dc881f7892b673

Expand All Messages | Collapse All Messages