Issue 84400043: code review 84400043: cmd/6g, cmd/8g: disable Duff's device on NaCl.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 84400043: code review 84400043: cmd/6g, cmd/8g: disable Duff's device on NaCl. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 12 months ago by remyoudompheng

Modified:
10 years, 12 months ago

Reviewers:
gobot, khr

CC:
rsc, dave_cheney.net, khr, golang-codereviews

Visibility:
Public.

Description

cmd/6g, cmd/8g: disable Duff's device on NaCl. Native Client forbids jumps/calls to arbitrary locations and enforces a particular alignement, which makes the Duff's device ineffective.

Patch Set 1 #

Patch Set 2 : diff -r 0bf0c11aea78 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0bf0c11aea78 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8cd4598a3975 https://go.googlecode.com/hg/ #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
M	src/cmd/6g/cgen.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/6g/ggen.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/8g/cgen.c	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/8g/ggen.c	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

remyoudompheng

Hello rsc@golang.org, dave@cheney.net, khr@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 12 months ago (2014-04-04 05:55:59 UTC) #1

khr

On 2014/04/04 05:55:59, remyoudompheng wrote: > Hello mailto:rsc@golang.org, mailto:dave@cheney.net, mailto:khr@golang.org (cc: > mailto:golang-codereviews@googlegroups.com), > > ...

10 years, 12 months ago (2014-04-04 06:26:53 UTC) #2

remyoudompheng

*** Submitted as https://code.google.com/p/go/source/detail?r=e426bfa69c19 *** cmd/6g, cmd/8g: disable Duff's device on NaCl. Native Client forbids ...

10 years, 12 months ago (2014-04-04 06:42:40 UTC) #3

gobot

10 years, 12 months ago (2014-04-04 07:09:41 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the darwin-amd64 builder.
See http://build.golang.org/log/f3371beca4b27ddff055c14ffc3e83031e0490d9

Expand All Messages | Collapse All Messages