Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7788)

Issue 84170043: code review 84170043: net: accept a few more errors in Accept4 wrapper (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by rsc
Modified:
10 years ago
Reviewers:
gobot, dfc, bradfitz
CC:
golang-codereviews, bradfitz
Visibility:
Public.

Description

net: accept a few more errors in Accept4 wrapper Fixes issue 7271.

Patch Set 1 #

Patch Set 2 : diff -r 4ca10cc10176 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 4ca10cc10176 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 106a49baaf84 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/pkg/net/sock_cloexec.go View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years ago (2014-04-03 18:37:37 UTC) #1
bradfitz
LGTM
10 years ago (2014-04-03 19:23:20 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=fba10e5a955a *** net: accept a few more errors in Accept4 wrapper Fixes ...
10 years ago (2014-04-03 20:10:50 UTC) #3
dfc
LGTM. Thank you On Fri, Apr 4, 2014 at 7:10 AM, <rsc@golang.org> wrote: > *** ...
10 years ago (2014-04-03 21:11:24 UTC) #4
gobot
10 years ago (2014-04-03 21:49:34 UTC) #5
Message was sent while issue was closed.
This CL appears to have broken the darwin-amd64-race-cheney builder.
See http://build.golang.org/log/2b5afcbfd8b6219d222c6d3dbf76c0522dde0dcf
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b