Issue 84050044: code review 84050044: go.tools/godoc: ignore //line comments in source code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 84050044: code review 84050044: go.tools/godoc: ignore //line comments in source code (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by gri

Modified:
10 years, 1 month ago

Reviewers:
rsc

CC:
bgarcia, rsc, golang-codereviews

Visibility:
Public.

Description

go.tools/godoc: ignore //line comments in source code Per suggestion from Gary Burd. Fixes issue 5247.

Patch Set 2 : diff -r 2354eab994b9 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 2354eab994b9 https://code.google.com/p/go.tools #

Total comments: 2

Patch Set 4 : diff -r 2354eab994b9 https://code.google.com/p/go.tools #

Patch Set 5 : diff -r 2354eab994b9 https://code.google.com/p/go.tools #

Patch Set 6 : diff -r 32bef99683d9 https://code.google.com/p/go.tools #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -1 line)			Patch
	M	godoc/cmdline_test.go	View	1 2 3	3 chunks	+14 lines, -1 line	0 comments	Download
	M	godoc/parser.go	View	1 2 3 4	2 chunks	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

gri

Hello bgarcia@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 1 month ago (2014-04-03 18:14:13 UTC) #1

rsc

https://codereview.appspot.com/84050044/diff/40001/godoc/parser.go File godoc/parser.go (right): https://codereview.appspot.com/84050044/diff/40001/godoc/parser.go#newcode34 godoc/parser.go:34: continue // not at the beginning of a line ...

10 years, 1 month ago (2014-04-03 19:50:07 UTC) #2

gri

PTAL https://codereview.appspot.com/84050044/diff/40001/godoc/parser.go File godoc/parser.go (right): https://codereview.appspot.com/84050044/diff/40001/godoc/parser.go#newcode34 godoc/parser.go:34: continue // not at the beginning of a ...

10 years, 1 month ago (2014-04-03 20:11:06 UTC) #4

gri

10 years, 1 month ago (2014-04-03 20:13:04 UTC) #6

*** Submitted as
https://code.google.com/p/go/source/detail?r=7fd88521490f&repo=tools ***

go.tools/godoc: ignore //line comments in source code

Per suggestion from Gary Burd.

Fixes issue 5247.

LGTM=rsc
R=bgarcia, rsc
CC=golang-codereviews
https://codereview.appspot.com/84050044

Expand All Messages | Collapse All Messages