Issue 83980043: code review 83980043: runtime: handle fault during runtime more like unexpect...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 83980043: code review 83980043: runtime: handle fault during runtime more like unexpect... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by rsc

Modified:
10 years, 1 month ago

Reviewers:
iant

CC:
dvyukov, iant, golang-codereviews

Visibility:
Public.

Description

runtime: handle fault during runtime more like unexpected fault address Delaying the runtime.throw until here will print more information. In particular it will print the signal and code values, which means it will show the fault address. The canpanic checks were added recently, in CL 75320043. They were just not added in exactly the right place.

Patch Set 1 #

Patch Set 2 : diff -r 4ca10cc10176 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 4ca10cc10176 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 881e5ceda5bf https://code.google.com/p/go/ #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -18 lines)			Patch
M	src/pkg/runtime/os_darwin.c	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/os_dragonfly.c	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/os_freebsd.c	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/os_linux.c	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/os_nacl.c	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/os_netbsd.c	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/os_openbsd.c	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/os_plan9.c	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/os_plan9_386.c	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/os_plan9_amd64.c	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/os_solaris.c	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/os_windows.c	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/signal_386.c	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/signal_amd64x.c	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/signal_arm.c	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello dvyukov (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 1 month ago (2014-04-03 10:53:02 UTC) #1

rsc

10 years, 1 month ago (2014-04-03 23:06:04 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=4b3b9cfc005c ***

runtime: handle fault during runtime more like unexpected fault address

Delaying the runtime.throw until here will print more information.
In particular it will print the signal and code values, which means
it will show the fault address.

The canpanic checks were added recently, in CL 75320043.
They were just not added in exactly the right place.

LGTM=iant
R=dvyukov, iant
CC=golang-codereviews
https://codereview.appspot.com/83980043

Expand All Messages | Collapse All Messages