Issue 838046: code review 838046: debug/macho: don't crash when reading non-Mach-O files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 838046: code review 838046: debug/macho: don't crash when reading non-Mach-O files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by gri

Modified:
15 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

debug/macho: don't crash when reading non-Mach-O files

Patch Set 1 #

Patch Set 2 : code review 838046: debug/macho: don't crash when reading non-Mach-O files #

Patch Set 3 : code review 838046: debug/macho: don't crash when reading non-Mach-O files #

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	src/pkg/debug/macho/file.go	View		2 chunks	+3 lines, -1 line	0 comments	Download
	M	src/pkg/debug/macho/file_test.go	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-04-01 22:30:30 UTC) #1