code review 83800043: net/http: clarify Request fields' client-vs-server semantics

net/http: clarify Request fields' client-vs-server semantics

Fixes Issue 7682

[bradfitz, 2014-04-03 00:12:30]

Hello golang-codereviews@googlegroups.com (cc: adg@golang.org,
dsymonds@golang.org, iant@golang.org),

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2014-04-03 00:30:20]

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.go
File src/pkg/net/http/request.go (right):

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:78: // For client requests, the empty string means
GET.
s/, the/an/

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:82: // requests), or the URL to access (for client
requests).
s/,//

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:84: // For server requests, it's created from the
URI supplied on
s/, it's created/the URL is parsed/

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:89: // For client requests, the URL's Host selects
the server to
s/, /
s/selects/specifies/

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:90: // connect to, while the Request's Host field
determines the
s/determines/specifies/

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:91: // Host header to send in the HTTP request. In
most cases they
s/header/& value/

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:91: // Host header to send in the HTTP request. In
most cases they
should we use the words "virtual host" here somewhere?

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:92: // should be the equal. The NewRequest function
returns
s/the // or s/the equal/equivalent/ or s/equal/same/
not sure if the sentence about NewRequest is necessary

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:122: // For client requests, certain headers are
automatically
s/,//

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:123: // added and may override values in Header. See
the
put a newline before "See"

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:154: // replying to this request (for servers), or
after sending
s/,//

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:158: // For server requests, Host is the host on
which the URL is
s/,//

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:158: // For server requests, Host is the host on
which the URL is
s/is/specifies/

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:163: // For client requests, Host optionally
overrides the the Host
s/the //

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:163: // For client requests, Host optionally
overrides the the Host
s/,//

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:164: // header to send when writing the HTTP
request. If empty,
"to send when writing the HTTP request" seems redundant

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:165: // the Request.Write method sends the value of
URL.Host.
s/sends/uses/

[bradfitz, 2014-04-03 03:05:53]

Hello golang-codereviews@googlegroups.com, adg@golang.org (cc:
dsymonds@golang.org, golang-codereviews@googlegroups.com, iant@golang.org),

Please take another look.

[bradfitz, 2014-04-03 03:05:53]

All done. PTAL.

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.go
File src/pkg/net/http/request.go (right):

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:91: // Host header to send in the HTTP request. In
most cases they
On 2014/04/03 00:30:20, adg wrote:
> should we use the words "virtual host" here somewhere?

No. That's a term servers sometimes use, but it's not necessarily a thing.

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:92: // should be the equal. The NewRequest function
returns
On 2014/04/03 00:30:20, adg wrote:
> s/the // or s/the equal/equivalent/ or s/equal/same/

done

> not sure if the sentence about NewRequest is necessary

Deleted. It's better explained below on Host anyway.

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:122: // For client requests, certain headers are
automatically
On 2014/04/03 00:30:20, adg wrote:
> s/,//

Pains me but done here and elsewhere.

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:123: // added and may override values in Header. See
the
On 2014/04/03 00:30:20, adg wrote:
> put a newline before "See"

Done.

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:164: // header to send when writing the HTTP
request. If empty,
On 2014/04/03 00:30:20, adg wrote:
> "to send when writing the HTTP request" seems redundant

Done.

https://codereview.appspot.com/83800043/diff/40001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:165: // the Request.Write method sends the value of
URL.Host.
On 2014/04/03 00:30:20, adg wrote:
> s/sends/uses/

Done.

[adg, 2014-04-03 03:55:29]

LGTM

https://codereview.appspot.com/83800043/diff/60001/src/pkg/net/http/request.go
File src/pkg/net/http/request.go (right):

https://codereview.appspot.com/83800043/diff/60001/src/pkg/net/http/request.g...
src/pkg/net/http/request.go:78: // For client requests, an empty string means
GET.
s/,//

[bradfitz, 2014-04-03 04:05:45]

*** Submitted as https://code.google.com/p/go/source/detail?r=ddfee9dfca20 ***

net/http: clarify Request fields' client-vs-server semantics

Fixes Issue 7682

LGTM=adg
R=golang-codereviews, adg
CC=dsymonds, golang-codereviews, iant
https://codereview.appspot.com/83800043