Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(244)

Issue 83580046: code review 83580046: go.tools/cmd/godex: update documentation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by gri
Modified:
10 years, 10 months ago
Reviewers:
adonovan
CC:
adonovan, golang-codereviews
Visibility:
Public.

Description

go.tools/cmd/godex: update documentation

Patch Set 1 #

Patch Set 2 : diff -r 2354eab994b9 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 2354eab994b9 https://code.google.com/p/go.tools #

Total comments: 5

Patch Set 4 : diff -r 6b4560421cda https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
M cmd/godex/doc.go View 1 2 3 2 chunks +24 lines, -10 lines 0 comments Download

Messages

Total messages: 5
gri
Hello adonovan@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
10 years, 10 months ago (2014-04-02 21:21:32 UTC) #1
adonovan
LGTM https://codereview.appspot.com/83580046/diff/40001/cmd/godex/doc.go File cmd/godex/doc.go (right): https://codereview.appspot.com/83580046/diff/40001/cmd/godex/doc.go#newcode28 cmd/godex/doc.go:28: // build os and architecture specific directory names ...
10 years, 10 months ago (2014-04-02 21:37:56 UTC) #2
gri
https://codereview.appspot.com/83580046/diff/40001/cmd/godex/doc.go File cmd/godex/doc.go (right): https://codereview.appspot.com/83580046/diff/40001/cmd/godex/doc.go#newcode28 cmd/godex/doc.go:28: // build os and architecture specific directory names from ...
10 years, 10 months ago (2014-04-02 21:42:08 UTC) #3
adonovan
https://codereview.appspot.com/83580046/diff/40001/cmd/godex/doc.go File cmd/godex/doc.go (right): https://codereview.appspot.com/83580046/diff/40001/cmd/godex/doc.go#newcode30 cmd/godex/doc.go:30: // "foo", a package "a/foo" is found before "b/foo". ...
10 years, 10 months ago (2014-04-02 21:44:43 UTC) #4
gri
10 years, 10 months ago (2014-04-07 20:49:14 UTC) #5
*** Submitted as
https://code.google.com/p/go/source/detail?r=0d756285d6c0&repo=tools ***

go.tools/cmd/godex: update documentation

LGTM=adonovan
R=adonovan
CC=golang-codereviews
https://codereview.appspot.com/83580046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b