code review 83520043: runtime: check that new slice cap doesn't overflow

runtime: check that new slice cap doesn't overflow

Fixes issue 7550.

[dave_cheney.net, 2014-04-02 10:06:58]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2014-04-02 10:26:57]

The test is not awesome. I could not find an example of a // run test that
expected failure. Suggestions gratefully received.

[iant, 2014-04-02 15:47:22]

On Wed, Apr 2, 2014 at 3:26 AM,  <dave@cheney.net> wrote:
> The test is not awesome. I could not find an example of a // run test
> that expected failure. Suggestions gratefully received.

There are several run tests that expect various sorts of failure.
For example, divmod.go, nil.go, nilptr.go.

Ian

[josharian, 2014-04-02 16:08:23]

> The test is not awesome. I could not find an example of a // run test
> that expected failure. Suggestions gratefully received.

How about something like http://play.golang.org/p/1g1EcEeQuc?

[dave_cheney.net, 2014-04-02 20:26:18]

Ian, thanks, I was looking for some version of // cmpout or //
errorcheck. I've helped myself to a copy of shouldPanic() from nil.go

+Josh, thanks for your suggestion, I went with Ian's as I felt there
was some precedent for that approach.

Cheers

Dave

On Thu, Apr 3, 2014 at 3:07 AM, Josh Bleecher Snyder
<josharian@gmail.com> wrote:
>> The test is not awesome. I could not find an example of a // run test
>> that expected failure. Suggestions gratefully received.
>
> How about something like http://play.golang.org/p/1g1EcEeQuc?

[dave_cheney.net, 2014-04-02 20:40:13]

Hello golang-codereviews@googlegroups.com, iant@golang.org, josharian@gmail.com
(cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-04-02 20:59:53]

LGTM

[dave_cheney.net, 2014-04-03 02:45:12]

*** Submitted as https://code.google.com/p/go/source/detail?r=779b773c87e6 ***

runtime: check that new slice cap doesn't overflow

Fixes issue 7550.

LGTM=iant
R=golang-codereviews, iant, josharian
CC=golang-codereviews
https://codereview.appspot.com/83520043