Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(710)

Issue 833044: code review 833044: simplify various code using new map index rule (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by rsc
Modified:
15 years ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

simplify various code using new map index rule

Patch Set 1 #

Patch Set 2 : code review 833044: simplify various code using new map index rule #

Patch Set 3 : code review 833044: simplify various code using new map index rule #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -194 lines) Patch
M src/cmd/godoc/index.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/goinstall/main.go View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/hgpatch/main.go View 1 chunk +7 lines, -7 lines 0 comments Download
M src/pkg/container/heap/heap_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/crypto/tls/ca_set.go View 1 chunk +2 lines, -10 lines 0 comments Download
M src/pkg/debug/dwarf/type_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/exp/eval/expr.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/eval/type.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/eval/value.go View 1 chunk +1 line, -4 lines 0 comments Download
M src/pkg/exp/ogle/rtype.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/expvar/expvar.go View 1 2 chunks +2 lines, -8 lines 0 comments Download
M src/pkg/flag/flag.go View 1 chunk +1 line, -5 lines 0 comments Download
M src/pkg/go/parser/parser_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/gob/decoder.go View 2 chunks +2 lines, -3 lines 0 comments Download
M src/pkg/gob/type.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/http/request.go View 6 chunks +20 lines, -33 lines 0 comments Download
M src/pkg/http/response.go View 4 chunks +8 lines, -9 lines 0 comments Download
M src/pkg/http/transfer.go View 1 chunk +2 lines, -5 lines 0 comments Download
M src/pkg/mime/type.go View 1 chunk +1 line, -2 lines 0 comments Download
M src/pkg/net/hosts.go View 1 chunk +1 line, -2 lines 0 comments Download
M src/pkg/once/once.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/reflect/deepequal.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/reflect/type.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/websocket/client.go View 1 3 chunks +18 lines, -63 lines 0 comments Download
M src/pkg/websocket/server.go View 1 2 chunks +5 lines, -8 lines 0 comments Download
M src/pkg/websocket/websocket_test.go View 3 chunks +5 lines, -5 lines 0 comments Download
M test/bench/k-nucleotide.go View 1 chunk +2 lines, -11 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years ago (2010-03-30 07:00:55 UTC) #1
gri1
LGTM On Tue, Mar 30, 2010 at 12:00 AM, <rsc@golang.org> wrote: > Reviewers: r, > ...
15 years ago (2010-03-30 17:26:01 UTC) #2
r
LGTM
15 years ago (2010-03-30 17:29:44 UTC) #3
rsc
15 years ago (2010-03-30 17:51:14 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=74daed8d4dbb ***

simplify various code using new map index rule

R=r
CC=golang-dev
http://codereview.appspot.com/833044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b