Issue 83080048: code review 83080048: crypto/tls: deflake TestConnReadNonzeroAndEOF

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 83080048: code review 83080048: crypto/tls: deflake TestConnReadNonzeroAndEOF (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by bradfitz

Modified:
10 years ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

crypto/tls: deflake TestConnReadNonzeroAndEOF Fixes Issue 7683

Patch Set 1 #

Patch Set 2 : diff -r 423f84bbb31e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 423f84bbb31e https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 38b8fac81a2c https://go.googlecode.com/hg/ #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -6 lines)			Patch
	M	src/pkg/crypto/tls/tls_test.go	View	1	4 chunks	+29 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

10 years ago (2014-04-02 18:52:04 UTC) #1

bradfitz

No. I also can't reproduce a hang. On Apr 2, 2014 12:34 PM, "Russ Cox" ...

10 years ago (2014-04-02 21:08:12 UTC) #3

bradfitz

10 years ago (2014-04-02 21:32:02 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=821b7172338c ***

crypto/tls: deflake TestConnReadNonzeroAndEOF

Fixes Issue 7683

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/83080048

Expand All Messages | Collapse All Messages