Issue 8286043: code review 8286043: go-tour: display images in websocket mode

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8286043: code review 8286043: go-tour: display images in websocket mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by adg

Modified:
11 years, 1 month ago

Reviewers:

CC:
golang-dev, gri

Visibility:
Public.

Description

go-tour: display images in websocket mode Fixes issue 31.

Patch Set 1 #

Patch Set 2 : diff -r dd4f0b547fbc https://code.google.com/p/go-tour #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
	M	js/socket.js	View		1 chunk	+11 lines, -4 lines	0 comments	Download
	M	static/tour.css	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour

11 years, 1 month ago (2013-04-02 21:31:42 UTC) #1

gri

LGTM I should say, it looks plausible. The CL description seems wrong; it can't be ...

11 years, 1 month ago (2013-04-02 21:43:16 UTC) #2

adg

On 3 April 2013 08:43, <gri@golang.org> wrote: > The CL description seems wrong; it can't ...

11 years, 1 month ago (2013-04-02 21:56:56 UTC) #3

adg

11 years, 1 month ago (2013-04-02 21:59:34 UTC) #4

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=0afa8a2c0850
***

go-tour: display images in websocket mode

Fixes issue 31.

R=golang-dev, gri
CC=golang-dev
https://codereview.appspot.com/8286043

Expand All Messages | Collapse All Messages