Issue 8270046: code review 8270046: go.talks: import socket.js changes from go-tour

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8270046: code review 8270046: go.talks: import socket.js changes from go-tour (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by adg

Modified:
11 years, 1 month ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

go.talks: import socket.js changes from go-tour

Patch Set 1 #

Patch Set 2 : diff -r 6ccd835b48d9 https://code.google.com/p/go.talks #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	present/js/socket.js	View		1 chunk	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks

11 years, 1 month ago (2013-04-02 23:46:31 UTC) #1

bradfitz

LGTM On Tue, Apr 2, 2013 at 4:46 PM, <adg@golang.org> wrote: > Reviewers: golang-dev1, > ...

11 years, 1 month ago (2013-04-02 23:49:32 UTC) #2

LGTM



On Tue, Apr 2, 2013 at 4:46 PM, <adg@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.**talks <https://code.google.com/p/go.talks>
>
>
> Description:
> go.talks: import socket.js changes from go-tour
>
> Please review this at
https://codereview.appspot.**com/8270046/<https://codereview.appspot.com/8270...
>
> Affected files:
>   M present/js/socket.js
>
>
> Index: present/js/socket.js
> ==============================**==============================**=======
> --- a/present/js/socket.js
> +++ b/present/js/socket.js
> @@ -38,11 +38,18 @@
>
>    function showMessage(o, m, className) {
>      var span = document.createElement("span")**;
> +    span.className = className;
> +    if (m.indexOf("IMAGE:") === 0) {
> +      var url = "data:image/png;base64," + m.substr(6);
> +      var img = document.createElement("img");
> +      img.src = url;
> +      span.appendChild(img);
> +    } else {
> +      m = m.replace(/&/g, "&amp;");
> +      m = m.replace(/</g, "&lt;");
> +      span.innerHTML = m;
> +    }
>      var needScroll = (o.scrollTop + o.offsetHeight) == o.scrollHeight;
> -    m = m.replace(/&/g, "&amp;");
> -    m = m.replace(/</g, "&lt;");
> -    span.innerHTML = m;
> -    span.className = className;
>      o.appendChild(span);
>      if (needScroll)
>          o.scrollTop = o.scrollHeight - o.offsetHeight;
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

adg

11 years, 1 month ago (2013-04-02 23:50:36 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=628278269f16&repo=talks ***

go.talks: import socket.js changes from go-tour

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/8270046

Expand All Messages | Collapse All Messages