Issue 825043: code review 825043: runtime: run deferred calls at Goexit

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 825043: code review 825043: runtime: run deferred calls at Goexit (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by rsc

Modified:
15 years ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

runtime: run deferred calls at Goexit baby step toward panic+recover. Fixes issue 349.

Patch Set 1 #

Patch Set 2 : code review 825043: runtime: run deferred calls at Goexit #

Patch Set 3 : code review 825043: runtime: run deferred calls at Goexit #

Patch Set 4 : code review 825043: runtime: run deferred calls at Goexit #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -52 lines)			Patch
M	src/pkg/runtime/386/asm.s	View	1 2 3	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/runtime/amd64/asm.s	View	1 2 3	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/runtime/arm/asm.s	View	1 2 3	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/runtime/extern.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/runtime/proc.c	View	1 2 3	8 chunks	+90 lines, -34 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-03-30 00:30:43 UTC) #1

rsc

Added unwindstack to clean up stack after goexit, moved gfget and gfput to bottom of ...

15 years ago (2010-03-30 01:30:14 UTC) #4

rsc

15 years ago (2010-03-30 04:48:26 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=2584b1cabce1 ***

runtime: run deferred calls at Goexit

baby step toward panic+recover.

Fixes issue 349.

R=r
CC=golang-dev
http://codereview.appspot.com/825043

Expand All Messages | Collapse All Messages