Issue 8241043: code review 8241043: go.exp/go/types: fix complex() built-in

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8241043: code review 8241043: go.exp/go/types: fix complex() built-in (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by gri

Modified:
11 years ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

go.exp/go/types: fix complex() built-in Fixes issue 5029.

Patch Set 1 #

Patch Set 2 : diff -r df65b42f772e https://code.google.com/p/go.exp #

Patch Set 3 : diff -r df65b42f772e https://code.google.com/p/go.exp #

Patch Set 4 : diff -r df65b42f772e https://code.google.com/p/go.exp #

Patch Set 5 : diff -r df65b42f772e https://code.google.com/p/go.exp #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -3 lines)			Patch
	M	go/types/builtins.go	View	1	2 chunks	+11 lines, -3 lines	0 comments	Download
	M	go/types/testdata/builtins.src	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.exp

11 years ago (2013-04-02 00:00:45 UTC) #1

gri

11 years ago (2013-04-02 16:53:43 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=d04a50a650e7&repo=exp ***

go.exp/go/types: fix complex() built-in

Fixes issue 5029.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/8241043

Expand All Messages | Collapse All Messages