Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(399)

Issue 824051: code review 824051: Added strings.FieldsFunc, a generalization of strings.F... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 11 months ago by Kyle C
Modified:
14 years, 11 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

Added strings.FieldsFunc, a generalization of strings.Fields in style of the strings.Trim*Func functions.

Patch Set 1 #

Patch Set 2 : code review 824051: Added strings.FieldsFunc, a generalization of strings.F... #

Total comments: 1

Patch Set 3 : code review 824051: Added strings.FieldsFunc, a generalization of strings.F... #

Total comments: 1

Patch Set 4 : code review 824051: Added strings.FieldsFunc, a generalization of strings.F... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M src/pkg/strings/strings.go View 1 2 3 2 chunks +9 lines, -2 lines 0 comments Download
M src/pkg/strings/strings_test.go View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Kyle C
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 11 months ago (2010-04-19 21:46:22 UTC) #1
r
works for me but you should provide a test. http://codereview.appspot.com/824051/diff/2001/3001 File src/pkg/strings/strings.go (right): http://codereview.appspot.com/824051/diff/2001/3001#newcode212 src/pkg/strings/strings.go:212: ...
14 years, 11 months ago (2010-04-19 22:47:04 UTC) #2
Kyle C
Hello golang-dev@googlegroups.com, r (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 11 months ago (2010-04-19 23:12:13 UTC) #3
r
code is good but please tweak the comment http://codereview.appspot.com/824051/diff/7001/1002 File src/pkg/strings/strings.go (right): http://codereview.appspot.com/824051/diff/7001/1002#newcode179 src/pkg/strings/strings.go:179: // ...
14 years, 11 months ago (2010-04-19 23:15:57 UTC) #4
Kyle C
Hello golang-dev@googlegroups.com, r (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 11 months ago (2010-04-19 23:35:10 UTC) #5
r
LGTM
14 years, 11 months ago (2010-04-19 23:36:09 UTC) #6
r
14 years, 11 months ago (2010-04-19 23:36:53 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=ad21a808b3c1 ***

Added strings.FieldsFunc, a generalization of strings.Fields in style of the
strings.Trim*Func functions.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/824051

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b