code review 824043: Unicode: provide an ability to supplement the case-mapp...

Unicode: provide an ability to supplement the case-mapping tables
in character and string case mapping routines.

Add a custom mapper for Turkish and Azeri.

A more general solution for deriving the case information from Unicode's
SpecialCasing.txt will require more work.

Fixes issue 703.

[r, 2010-03-31 00:34:21]

Hello rsc (cc: golang-dev@googlegroups.com, mdakin@gmail.com),

I'd like you to review this change.

[rsc1, 2010-03-31 00:39:31]

LGTM

(The (r) in BUG(r) is necessary but does not appear in the godoc output.)

http://codereview.appspot.com/824043/diff/1/2
File src/pkg/strings/strings.go (right):

http://codereview.appspot.com/824043/diff/1/2#newcode301
src/pkg/strings/strings.go:301: // upper case, giving priority to the special
casing rules.
s/upper/lower/

http://codereview.appspot.com/824043/diff/1/2#newcode307
src/pkg/strings/strings.go:307: // upper case, giving priority to the special
casing rules.
s/upper/title/

http://codereview.appspot.com/824043/diff/1/6
File src/pkg/unicode/letter.go (right):

http://codereview.appspot.com/824043/diff/1/6#newcode32
src/pkg/unicode/letter.go:32: // TODO: Provide a mechanism for full case folding
(those that involve
If you move this out of the doc comment you can say

// BUG(r): There should be a mechanism for full case folding
// (those that involve multiple runes in the input or output).

at top level as its own comment, and it appears in the
BUGS section of the godoc output.

http://codereview.appspot.com/824043/diff/1/6#newcode41
src/pkg/unicode/letter.go:41: // TODO: Provide a mechanism for full case folding
(those that involve
Then you can drop this one.
(But keep Methods of SpecialCase...)

[r, 2010-03-31 00:51:07]

*** Submitted as http://code.google.com/p/go/source/detail?r=477b3015c052 ***

Unicode: provide an ability to supplement the case-mapping tables
in character and string case mapping routines.

Add a custom mapper for Turkish and Azeri.

A more general solution for deriving the case information from Unicode's
SpecialCasing.txt will require more work.

Fixes issue 703.

R=rsc, rsc1
CC=golang-dev, mdakin
http://codereview.appspot.com/824043