code review 822044: godashboard: new stylesheet, build status pagination

godashboard: new stylesheet, build status pagination

[adg, 2010-03-31 03:42:45]

Hello rsc, gri (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r, 2010-03-31 04:06:58]

is there a demo to look at?

http://codereview.appspot.com/822044/diff/2001/3001
File misc/dashboard/godashboard/gobuild.py (right):

http://codereview.appspot.com/822044/diff/2001/3001#newcode127
misc/dashboard/godashboard/gobuild.py:127: if not page > 0:
why not if page <= 0 ?

[r, 2010-03-31 04:18:43]

LGTM but i'm a latecomer

[adg, 2010-03-31 04:49:11]

Hello rsc, gri, r (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2010-03-31 04:53:04]

Russ, does this fit on your MacBook now?

On 31 March 2010 15:49,  <adg@golang.org> wrote:
> Hello rsc, gri, r (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
> http://codereview.appspot.com/822044/show
>

[adg, 2010-03-31 04:53:12]

Russ, does this fit on your MacBook now?

On 31 March 2010 15:49,  <adg@golang.org> wrote:
> Hello rsc, gri, r (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
> http://codereview.appspot.com/822044/show
>

[adg, 2010-03-31 04:58:43]

Russ, does this fit on your MacBook now?

On 31 March 2010 15:49,  <adg@golang.org> wrote:
> Hello rsc, gri, r (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
> http://codereview.appspot.com/822044/show
>

[rsc, 2010-03-31 05:30:16]

looks fantastic to me.

[adg, 2010-03-31 05:30:49]

Hello rsc, gri, r (cc: golang-dev@googlegroups.com),

Please take another look.

[gri, 2010-03-31 05:39:47]

The new page looks great. Perhaps the only suggestion I have is to perhaps
write "RED" or "GREEN" next to the title "Build Status"; or perhaps color
the title according to the actual status. This way the current status is
immediately visible even when one doesn't look at the top-most page.

- Robert

On Tue, Mar 30, 2010 at 10:30 PM, <adg@golang.org> wrote:

> Hello rsc, gri, r (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
> http://codereview.appspot.com/822044/show
>

[gri, 2010-03-31 05:48:19]

One more thing:

I'd prefer that all the navigation "buttons" at the bottom are visible all
the time, so that one doesn't have to move the mouse when going from the
first to the second and the third page. For instance, on the first page,
there's only "next", on the 2nd there's "prev" and "next; also, there should
be a "top". Can we always show "prev", "top", and "next" and have the ones
grey'ed out that don't have an effect?

And apropos the Build Status: Perhaps the individual column headings should
be colored red or green instead of the title. For instance, now, "linux arm
android" would be red, all other ones would be green.

But overall very nice! Thanks.
- Robert

On Tue, Mar 30, 2010 at 10:39 PM, Robert Griesemer <gri@golang.org> wrote:

> The new page looks great. Perhaps the only suggestion I have is to perhaps
> write "RED" or "GREEN" next to the title "Build Status"; or perhaps color
> the title according to the actual status. This way the current status is
> immediately visible even when one doesn't look at the top-most page.
>
> - Robert
>
>
> On Tue, Mar 30, 2010 at 10:30 PM, <adg@golang.org> wrote:
>
>> Hello rsc, gri, r (cc: golang-dev@googlegroups.com),
>>
>> Please take another look.
>>
>>
>> http://codereview.appspot.com/822044/show
>>
>
>

[adg, 2010-03-31 06:01:20]

*** Submitted as http://code.google.com/p/go/source/detail?r=e56803580234 ***

godashboard: new stylesheet, build status pagination

R=rsc, gri, r
CC=golang-dev
http://codereview.appspot.com/822044

[adg, 2010-03-31 06:03:12]

Now deployed: http://godashboard.appspot.com/

On 31 March 2010 16:48, Robert Griesemer <gri@golang.org> wrote:
> One more thing:
> I'd prefer that all the navigation "buttons" at the bottom are visible all
> the time, so that one doesn't have to move the mouse when going from the
> first to the second and the third page. For instance, on the first page,
> there's only "next", on the 2nd there's "prev" and "next; also, there should
> be a "top". Can we always show "prev", "top", and "next" and have the ones
> grey'ed out that don't have an effect?

Good suggestions. Done.

> And apropos the Build Status: Perhaps the individual column headings should
> be colored red or green instead of the title. For instance, now, "linux arm
> android" would be red, all other ones would be green.

It's a nice idea, but it would require more code than I have time for
right now. I thought it best to just get these changes out the door.
I'll look at that next time (which will be soon).

Thanks,
Andrew

[r2, 2010-03-31 06:23:55]

please do not go too colorful, and for the genetically deprived such as myself
pretty please do not go red/green.

-rob

On Mar 30, 2010, at 11:02 PM, Andrew Gerrand wrote:

> Now deployed: http://godashboard.appspot.com/
> 
> On 31 March 2010 16:48, Robert Griesemer <gri@golang.org> wrote:
>> One more thing:
>> I'd prefer that all the navigation "buttons" at the bottom are visible all
>> the time, so that one doesn't have to move the mouse when going from the
>> first to the second and the third page. For instance, on the first page,
>> there's only "next", on the 2nd there's "prev" and "next; also, there should
>> be a "top". Can we always show "prev", "top", and "next" and have the ones
>> grey'ed out that don't have an effect?
> 
> Good suggestions. Done.
> 
>> And apropos the Build Status: Perhaps the individual column headings should
>> be colored red or green instead of the title. For instance, now, "linux arm
>> android" would be red, all other ones would be green.
> 
> It's a nice idea, but it would require more code than I have time for
> right now. I thought it best to just get these changes out the door.
> I'll look at that next time (which will be soon).
> 
> Thanks,
> Andrew