Issue 8213043: code review 8213043: cmd/gc: be more tolerant with recursive types when chec...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8213043: code review 8213043: cmd/gc: be more tolerant with recursive types when chec... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by remyoudompheng

Modified:
12 years ago

Reviewers:
costinc

CC:
golang-dev, DMorsing

Visibility:
Public.

Description

cmd/gc: be more tolerant with recursive types when checking map types. A nested TFORW type would push algtype1 into an impossible case. Fixes issue 5125.

Patch Set 2 : diff -r 5260abd6df41 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5260abd6df41 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 5260abd6df41 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r cfe93dfc5788 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r fffdd5faa5e9 https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -2 lines)			Patch
M	src/cmd/gc/subr.c	View	1 2 3	2 chunks	+11 lines, -2 lines	0 comments	Download
A	test/fixedbugs/issue5125.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
A	test/fixedbugs/issue5125.dir/bug.go	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
A	test/fixedbugs/issue5125.dir/main.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2013-03-31 10:26:22 UTC) #1

DMorsing

LGTM https://codereview.appspot.com/8213043/diff/5001/src/cmd/gc/subr.c File src/cmd/gc/subr.c (right): https://codereview.appspot.com/8213043/diff/5001/src/cmd/gc/subr.c#newcode679 src/cmd/gc/subr.c:679: switch(bad == nil ? key->etype : bad->etype) { ...

12 years ago (2013-04-02 21:19:05 UTC) #3

remyoudompheng

*** Submitted as https://code.google.com/p/go/source/detail?r=e8d3578a3f34 *** cmd/gc: be more tolerant with recursive types when checking map ...

12 years ago (2013-04-03 06:18:52 UTC) #4

Message was sent while issue was closed.

Why is bad tested for null at subr.c:547 but not at subr.c:554?

Expand All Messages | Collapse All Messages