Issue 821044: code review 821044: Effective Go: update maps description regarding lookup ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 821044: code review 821044: Effective Go: update maps description regarding lookup ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by r

Modified:
15 years ago

Reviewers:

CC:
rsc, gri, iant, golang-dev

Visibility:
Public.

Description

Effective Go: update maps description regarding lookup of nonexistent entry.

Patch Set 2 : code review 821044: Effective Go: update maps description regarding lookup ... #

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -5 lines)			Patch
	M	doc/effective_go.html	View	1	4 chunks	+20 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello rsc, gri, iant (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-03-30 17:44:58 UTC) #1

gri

LGTM http://codereview.appspot.com/821044/diff/1/2 File doc/effective_go.html (right): http://codereview.appspot.com/821044/diff/1/2#newcode1131 doc/effective_go.html:1131: is not present in the map will return ...

15 years ago (2010-03-30 18:18:46 UTC) #3

15 years ago (2010-03-30 18:21:52 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=5d9de6dd5967 ***

Effective Go: update maps description regarding lookup of nonexistent entry.

R=rsc, gri, iant
CC=golang-dev
http://codereview.appspot.com/821044

Expand All Messages | Collapse All Messages