Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1035)

Issue 82040044: code review 82040044: syscall: add Unsetenv(string)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by minux1
Modified:
9 years, 10 months ago
Visibility:
Public.

Description

syscall: add Unsetenv(string) also fix the TODO (pass through to C) in Clearenv. Update issue 6423

Patch Set 1 #

Patch Set 2 : diff -r b1f6ff3c9f0e https://code.google.com/p/go #

Patch Set 3 : diff -r b1f6ff3c9f0e https://code.google.com/p/go #

Patch Set 4 : diff -r b3405f9c2e32 https://code.google.com/p/go #

Patch Set 5 : diff -r b3405f9c2e32 https://code.google.com/p/go #

Patch Set 6 : diff -r b3405f9c2e32 https://code.google.com/p/go #

Patch Set 7 : diff -r b3405f9c2e32 https://code.google.com/p/go #

Patch Set 8 : diff -r 87c97fd0aee6 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -2 lines) Patch
M src/pkg/runtime/cgo/gcc_setenv.c View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M src/pkg/runtime/cgo/setenv.c View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/runtime/env_posix.c View 1 2 3 4 2 chunks +22 lines, -0 lines 0 comments Download
M src/pkg/syscall/env_plan9.go View 1 2 3 4 5 6 1 chunk +22 lines, -0 lines 0 comments Download
M src/pkg/syscall/env_unix.go View 1 2 3 4 2 chunks +20 lines, -2 lines 0 comments Download
M src/pkg/syscall/env_windows.go View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 22
minux1
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years ago (2014-03-29 08:29:23 UTC) #1
brainman
LGTM Alex
10 years ago (2014-03-29 08:41:12 UTC) #2
dfc
not lgtm, issue 6423 doesn't feel like it warrants adding a new syscall for 1.3. ...
10 years ago (2014-03-29 08:48:27 UTC) #3
iant
Is this appropriate during a feature freeze? I don't understand the point of the issue. ...
10 years ago (2014-03-29 16:43:25 UTC) #4
minux1
On Mar 29, 2014 12:43 PM, <iant@golang.org> wrote: > Is this appropriate during a feature ...
10 years ago (2014-03-29 17:27:48 UTC) #5
Peter Waller
On 2014/03/29 16:43:25, iant wrote: > Is this appropriate during a feature freeze? > > ...
9 years, 11 months ago (2014-04-09 07:52:24 UTC) #6
iant
On 2014/04/09 07:52:24, Peter Waller wrote: > > I have encountered a direct need for ...
9 years, 11 months ago (2014-04-09 13:47:13 UTC) #7
bradfitz
Well, the issue is flagged Go 1.3. This should either be finished (with passing to ...
9 years, 11 months ago (2014-04-11 03:20:43 UTC) #8
minux1
On Apr 10, 2014 11:20 PM, <bradfitz@golang.org> wrote: > Well, the issue is flagged Go ...
9 years, 11 months ago (2014-04-11 06:22:36 UTC) #9
iant
On Thu, Apr 10, 2014 at 11:22 PM, minux <minux.ma@gmail.com> wrote: > > On Apr ...
9 years, 11 months ago (2014-04-11 14:26:28 UTC) #10
minux1
On Apr 11, 2014 10:26 AM, "Ian Lance Taylor" <iant@golang.org> wrote: > > On Thu, ...
9 years, 11 months ago (2014-04-11 15:57:51 UTC) #11
bradfitz
I'd say just do it and see how invasive it looks. Worst case the work ...
9 years, 11 months ago (2014-04-11 16:46:21 UTC) #12
Peter Waller
On 2014/04/09 13:47:13, iant wrote: > I understand, but when you invoke the child process, ...
9 years, 11 months ago (2014-04-11 19:53:00 UTC) #13
iant
On Fri, Apr 11, 2014 at 12:53 PM, <peter.waller@gmail.com> wrote: > On 2014/04/09 13:47:13, iant ...
9 years, 11 months ago (2014-04-11 20:00:49 UTC) #14
minux1
PTAL. I implemented everything except for Plan 9. I need advice from Plan 9 experts ...
9 years, 11 months ago (2014-04-13 18:09:24 UTC) #15
minux1
PTAL. syscall.Unsetenv is implemented on all supported platforms. On Sun, Apr 13, 2014 at 3:30 ...
9 years, 11 months ago (2014-04-13 19:45:32 UTC) #16
minux1
On Sun, Apr 13, 2014 at 4:56 PM, David du Colombier <0intro@gmail.com>wrote: > > PTAL. ...
9 years, 11 months ago (2014-04-13 21:28:40 UTC) #17
minux1
On Sun, Apr 13, 2014 at 5:28 PM, minux <minux.ma@gmail.com> wrote: > > On Sun, ...
9 years, 11 months ago (2014-04-13 21:40:32 UTC) #18
bradfitz
R=rsc,iant
9 years, 11 months ago (2014-04-14 19:59:06 UTC) #19
rsc
I agree with Ian. Let's put this off until Go 1.4. Being marked Go 1.3 ...
9 years, 11 months ago (2014-04-14 20:05:28 UTC) #20
rsc
R=close Please 'hg mail' after 1.3 to reopen this CL.
9 years, 11 months ago (2014-04-17 02:46:12 UTC) #21
lann
9 years, 11 months ago (2014-04-27 07:05:57 UTC) #22
In case the merits of this request are still under debate, here's a bit of code
we all execute that treats unset and empty env vars differently:

https://github.com/github/git-msysgit/blob/0fce85db5bf812147941e10c489253286b...

Specifically, most git commands will fail with `GIT_DIR=` vs GIT_DIR being
unset.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b