code review 8178046: go.exp/go/types: don't crash in Object.Pos()

go.exp/go/types: don't crash in Object.Pos()

Missed one case, apparently. Changes all cases
to look the same.

Fixes issue 5143.

[gri, 2013-04-01 23:15:28]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.exp

[bradfitz, 2013-04-01 23:24:46]

LGTM


On Mon, Apr 1, 2013 at 4:15 PM, <gri@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.**exp <https://code.google.com/p/go.exp>
>
>
> Description:
> go.exp/go/types: don't crash in Object.Pos()
>
> Missed one case, appearently. Changes all cases
> to look the same.
>
> Fixes issue 5143.
>
> Please review this at
https://codereview.appspot.**com/8178046/<https://codereview.appspot.com/8178...
>
> Affected files:
>   M go/types/objects.go
>
>
> Index: go/types/objects.go
> ==============================**==============================**=======
> --- a/go/types/objects.go
> +++ b/go/types/objects.go
> @@ -91,13 +91,16 @@
>  func (obj *Func) GetType() Type     { return obj.Type }
>
>  func (obj *Package) GetPos() token.Pos {
> -       if obj.spec != nil {
> -               return obj.spec.Pos()
> +       if obj.spec == nil {
> +               return token.NoPos
>         }
> -       return token.NoPos
> +       return obj.spec.Pos()
>  }
>
>  func (obj *Const) GetPos() token.Pos {
> +       if obj.spec == nil {
> +               return token.NoPos
> +       }
>         for _, n := range obj.spec.Names {
>                 if n.Name == obj.Name {
>                         return n.Pos()
> @@ -106,10 +109,10 @@
>         return token.NoPos
>  }
>  func (obj *TypeName) GetPos() token.Pos {
> -       if obj.spec != nil {
> -               return obj.spec.Pos()
> +       if obj.spec == nil {
> +               return token.NoPos
>         }
> -       return token.NoPos
> +       return obj.spec.Pos()
>  }
>
>  func (obj *Var) GetPos() token.Pos {
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[gri, 2013-04-01 23:28:01]

*** Submitted as
https://code.google.com/p/go/source/detail?r=df65b42f772e&repo=exp ***

go.exp/go/types: don't crash in Object.Pos()

Missed one case, apparently. Changes all cases
to look the same.

Fixes issue 5143.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/8178046