Issue 816042: code review 816042: testing/regexp: use recover.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 816042: code review 816042: testing/regexp: use recover. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by r

Modified:
15 years ago

Reviewers:
rsc

CC:
rsc, golang-dev

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -59 lines)			Patch
	M	src/pkg/regexp/regexp.go	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	src/pkg/testing/regexp.go	View		16 chunks	+32 lines, -58 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-03-31 23:11:56 UTC) #1

rsc1

LGTM http://codereview.appspot.com/816042/diff/1/2 File src/pkg/regexp/regexp.go (right): http://codereview.appspot.com/816042/diff/1/2#newcode268 src/pkg/regexp/regexp.go:268: p.re = nil can delete this line. http://codereview.appspot.com/816042/diff/1/3 ...

15 years ago (2010-04-01 00:19:42 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=6fdf92d8a9df *** testing/regexp: use recover. R=rsc CC=golang-dev http://codereview.appspot.com/816042 Committer: Rob Pike <r@golang.org>

15 years ago (2010-04-01 00:57:51 UTC) #3

*** Abandoned ***

Expand All Messages | Collapse All Messages