Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4162)

Issue 81330045: code review 81330045: cmd/dist: use GOHOSTARCH/GOHOSTOS instead of GOOS/GOARC... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by atom
Modified:
9 years, 11 months ago
Reviewers:
gobot, rsc, dfc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

cmd/dist: use GOHOSTARCH/GOHOSTOS instead of GOOS/GOARCH for host libraries and binaries Fixes issue 6559

Patch Set 1 #

Patch Set 2 : diff -r f8a3140e3874 https://code.google.com/p/go/ #

Patch Set 3 : diff -r f8a3140e3874 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 8aad251d4bd1 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 4c91e8fa0ebf https://code.google.com/p/go/ #

Patch Set 6 : diff -r 4c91e8fa0ebf https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M src/cmd/dist/build.c View 1 2 3 6 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 6
atom
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
10 years ago (2014-03-29 10:32:24 UTC) #1
atom
I am not sure whether this CL fixes the issue entirely. Please test.
10 years ago (2014-03-29 10:33:11 UTC) #2
rsc
LGTM Thanks, it does fix the problem I was seeing.
9 years, 11 months ago (2014-04-15 06:44:00 UTC) #3
atom
*** Submitted as https://code.google.com/p/go/source/detail?r=4c6d48b65d66 *** cmd/dist: use GOHOSTARCH/GOHOSTOS instead of GOOS/GOARCH for host libraries and ...
9 years, 11 months ago (2014-04-15 06:46:29 UTC) #4
gobot
This CL appears to have broken the darwin-amd64-cheney builder. See http://build.golang.org/log/0e3230720dc54a82eeb374fa07c3bc4532feb071
9 years, 11 months ago (2014-04-15 07:03:18 UTC) #5
dfc
9 years, 11 months ago (2014-04-15 07:06:25 UTC) #6
I don't think this is related. I think the machine may have gone to
sleep during the test, causing time to shift violently when it awoke.

On Tue, Apr 15, 2014 at 5:03 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the darwin-amd64-cheney builder.
> See http://build.golang.org/log/0e3230720dc54a82eeb374fa07c3bc4532feb071
>
>
> https://codereview.appspot.com/81330045/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b