Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(47)

Issue 8132044: code review 8132044: time: Allow Parse and Format to handle time zone offset...

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by ulf
Modified:
11 years, 7 months ago
Reviewers:
r
CC:
golang-dev, r, bradfitz
Visibility:
Public.

Description

time: Allow Parse and Format to handle time zone offsets with seconds Adds layout cases with seconds for stdISO8601 and stdNumTZ with and without colons. Update time.Format to append seconds for those cases. Fixes issue 4934.

Patch Set 1 #

Patch Set 2 : diff -r 7505bf6d8988 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7505bf6d8988 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -40 lines) Patch
M src/pkg/time/format.go View 1 7 chunks +88 lines, -40 lines 0 comments Download
M src/pkg/time/time_test.go View 1 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 8
ulf
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 11 months ago (2013-03-29 10:34:43 UTC) #1
r
Please remind us of this CL after Go 1.1 is out. -rob
11 years, 11 months ago (2013-03-29 20:50:35 UTC) #2
bradfitz
R=r Rob wanted to be reminded when Go 1.1 is out. It is now out, ...
11 years, 9 months ago (2013-06-04 22:33:12 UTC) #3
bradfitz
R=r Ping.
11 years, 7 months ago (2013-07-23 22:13:13 UTC) #4
r
LGTM
11 years, 7 months ago (2013-07-31 03:44:18 UTC) #5
r
This CL is good. Please sign the CLA as documented at the bottom of http://golang.org/doc/contribute.html
11 years, 7 months ago (2013-07-31 03:46:13 UTC) #6
ulf
On 2013/07/31 03:46:13, r wrote: > This CL is good. Please sign the CLA as ...
11 years, 7 months ago (2013-07-31 05:55:34 UTC) #7
r
11 years, 7 months ago (2013-07-31 06:11:08 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=40fbff3fa50a ***

time: Allow Parse and Format to handle time zone offsets with seconds

Adds layout cases with seconds for stdISO8601 and stdNumTZ with and without
colons. Update time.Format to append seconds for those cases.

Fixes issue 4934.

R=golang-dev, r, bradfitz
CC=golang-dev
https://codereview.appspot.com/8132044

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b