Issue 813043: code review 813043: http: fix documentation example

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 813043: code review 813043: http: fix documentation example (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 12 months ago by rsc

Modified:
14 years, 12 months ago

Reviewers:

CC:
adg, golang-dev

Visibility:
Public.

Patch Set 2 : code review 813043: http: fix documentation example #

Total comments: 1

Patch Set 3 : code review 813043: http: fix documentation example #

Created: 14 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	src/pkg/http/server.go	View	1 2	1 chunk	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 12 months ago (2010-04-06 05:40:11 UTC) #1

adg

LGTM but: http://codereview.appspot.com/813043/diff/2001/3001 File src/pkg/http/server.go (right): http://codereview.appspot.com/813043/diff/2001/3001#newcode585 src/pkg/http/server.go:585: // http.Handle("/hello", http.HandlerFunc(HelloServer)) use HandleFunc instead: http.HandleFunc("/hello", ...

14 years, 12 months ago (2010-04-06 05:49:34 UTC) #2

rsc

14 years, 12 months ago (2010-04-06 05:55:07 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=7e28ef5b5fd3 ***

http: fix documentation example

R=adg
CC=golang-dev
http://codereview.appspot.com/813043

Expand All Messages | Collapse All Messages