Issue 81240043: code review 81240043: fmt: fix go syntax formatting of []byte(nil)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 81240043: code review 81240043: fmt: fix go syntax formatting of []byte(nil) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by minux1

Modified:
9 years, 12 months ago

Reviewers:
rsc

CC:
r, adg, rsc, golang-codereviews

Visibility:
Public.

Description

fmt: fix go syntax formatting of []byte(nil) Fixes issue 7639.

Patch Set 2 : diff -r ed3e89f781c1 https://code.google.com/p/go #

Patch Set 3 : diff -r ed3e89f781c1 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r ed3e89f781c1 https://code.google.com/p/go #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	src/pkg/fmt/fmt_test.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/pkg/fmt/print.go	View	1 2 3	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

minux1

Hello r@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 1 month ago (2014-03-27 05:05:53 UTC) #1

adg

https://codereview.appspot.com/81240043/diff/40001/src/pkg/fmt/print.go File src/pkg/fmt/print.go (right): https://codereview.appspot.com/81240043/diff/40001/src/pkg/fmt/print.go#newcode783 src/pkg/fmt/print.go:783: println("!!") delete

10 years, 1 month ago (2014-03-27 05:12:03 UTC) #2

minux1

PTAL. On Thu, Mar 27, 2014 at 1:12 AM, <adg@golang.org> wrote: > https://codereview.appspot.com/81240043/diff/40001/src/ > pkg/fmt/print.go#newcode783 ...

10 years, 1 month ago (2014-03-27 05:18:53 UTC) #3

rsc

10 years ago (2014-04-03 20:11:08 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=a6073283d113 ***

fmt: fix go syntax formatting of []byte(nil)
Fixes issue 7639.

LGTM=rsc
R=r, adg, rsc
CC=golang-codereviews
https://codereview.appspot.com/81240043

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages