code review 81210043: syscall: add SendmsgN for BSD variants, Linux and Solaris

syscall: add SendmsgN for BSD variants, Linux and Solaris

SendmsgN is an alternate version Sendmsg that also returns
the number of bytes transferred, instead of just the error.

Update issue 7645

[mikio, 2014-03-27 04:03:02]

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[aram, 2014-03-27 12:08:32]

LGTM

https://codereview.appspot.com/81210043/diff/30003/src/pkg/syscall/syscall_so...
File src/pkg/syscall/syscall_solaris.go (right):

https://codereview.appspot.com/81210043/diff/30003/src/pkg/syscall/syscall_so...
src/pkg/syscall/syscall_solaris.go:418: return
Explicit return.

https://codereview.appspot.com/81210043/diff/30003/src/pkg/syscall/syscall_so...
src/pkg/syscall/syscall_solaris.go:423: return
Same.

[iant, 2014-03-27 20:24:48]

It seems that if we do this for one Unix variant we should do it for all.  But
we shouldn't do it for all right now, because that would violate the feature
freeze.  Unless we consider it as a bug fix for http://golang.org/issue/7645.

[bradfitz, 2014-03-27 20:28:49]

Seems worth fixing.
 On Mar 27, 2014 1:24 PM, <iant@golang.org> wrote:

> It seems that if we do this for one Unix variant we should do it for
> all.  But we shouldn't do it for all right now, because that would
> violate the feature freeze.  Unless we consider it as a bug fix for
> http://golang.org/issue/7645.
>
> https://codereview.appspot.com/81210043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[mikio, 2014-03-28 04:29:51]

PTAL, but we will wait for consensus.

> Let's do them all at once.

done.

> And please send a note to golang-dev about whether this is appropriate at this
stage of the release process.

done.

https://codereview.appspot.com/81210043/diff/30003/src/pkg/syscall/syscall_so...
File src/pkg/syscall/syscall_solaris.go (right):

https://codereview.appspot.com/81210043/diff/30003/src/pkg/syscall/syscall_so...
src/pkg/syscall/syscall_solaris.go:418: return
On 2014/03/27 12:08:33, aram wrote:
> Explicit return.

Done.

https://codereview.appspot.com/81210043/diff/30003/src/pkg/syscall/syscall_so...
src/pkg/syscall/syscall_solaris.go:423: return
On 2014/03/27 12:08:33, aram wrote:
> Same.

Done.

[bradfitz, 2014-03-28 14:04:42]

In the commit message, instead of,

"SendmsgN is a replacement for Sendmsg so that we can receive
a number of bytes transferred correctly."

It's more like:

"SendmsgN is an alternate version Sendmsg that also returns the number of
bytes transferred, instead of just the error."

(since we're not replacing Sendmsg)



On Thu, Mar 27, 2014 at 9:29 PM, <mikioh.mikioh@gmail.com> wrote:

> PTAL, but we will wait for consensus.
>
>  Let's do them all at once.
>>
>
> done.
>
>  And please send a note to golang-dev about whether this is appropriate
>>
> at this stage of the release process.
>
> done.
>
>
> https://codereview.appspot.com/81210043/diff/30003/src/
> pkg/syscall/syscall_solaris.go
> File src/pkg/syscall/syscall_solaris.go (right):
>
> https://codereview.appspot.com/81210043/diff/30003/src/
> pkg/syscall/syscall_solaris.go#newcode418
> src/pkg/syscall/syscall_solaris.go:418: return
> On 2014/03/27 12:08:33, aram wrote:
>
>> Explicit return.
>>
>
> Done.
>
> https://codereview.appspot.com/81210043/diff/30003/src/
> pkg/syscall/syscall_solaris.go#newcode423
> src/pkg/syscall/syscall_solaris.go:423: return
> On 2014/03/27 12:08:33, aram wrote:
>
>> Same.
>>
>
> Done.
>
> https://codereview.appspot.com/81210043/
>

[iant, 2014-03-28 21:56:45]

LGTM

Thanks.

[mikio, 2014-03-29 00:19:55]

done, thanks.

On Fri, Mar 28, 2014 at 11:04 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> In the commit message, instead of,
>
> "SendmsgN is a replacement for Sendmsg so that we can receive
> a number of bytes transferred correctly."
>
> It's more like:
>
> "SendmsgN is an alternate version Sendmsg that also returns the number of
> bytes transferred, instead of just the error."
>
> (since we're not replacing Sendmsg)
>
>
>
> On Thu, Mar 27, 2014 at 9:29 PM, <mikioh.mikioh@gmail.com> wrote:
>>
>> PTAL, but we will wait for consensus.
>>
>>> Let's do them all at once.
>>
>>
>> done.
>>
>>> And please send a note to golang-dev about whether this is appropriate
>>
>> at this stage of the release process.
>>
>> done.
>>
>>
>>
>>
https://codereview.appspot.com/81210043/diff/30003/src/pkg/syscall/syscall_so...
>> File src/pkg/syscall/syscall_solaris.go (right):
>>
>>
>>
https://codereview.appspot.com/81210043/diff/30003/src/pkg/syscall/syscall_so...
>> src/pkg/syscall/syscall_solaris.go:418: return
>> On 2014/03/27 12:08:33, aram wrote:
>>>
>>> Explicit return.
>>
>>
>> Done.
>>
>>
>>
https://codereview.appspot.com/81210043/diff/30003/src/pkg/syscall/syscall_so...
>> src/pkg/syscall/syscall_solaris.go:423: return
>> On 2014/03/27 12:08:33, aram wrote:
>>>
>>> Same.
>>
>>
>> Done.
>>
>> https://codereview.appspot.com/81210043/
>
>

[mikio, 2014-03-29 00:28:50]

*** Submitted as https://code.google.com/p/go/source/detail?r=43b39ae536b6 ***

syscall: add SendmsgN for BSD variants, Linux and Solaris

SendmsgN is an alternate version Sendmsg that also returns
the number of bytes transferred, instead of just the error.

Update issue 7645

LGTM=aram, iant
R=iant, aram, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/81210043

[gobot, 2014-03-29 00:41:26]

This CL appears to have broken the windows-386-ec2 builder.
See http://build.golang.org/log/11aee4e5d82af80a1d836fab10a2745a59d1f146