Issue 812041: code review 812041: libcgo: initial mingw port work - builds but untested

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 812041: code review 812041: libcgo: initial mingw port work - builds but untested (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by Joe Poirier

Modified:
14 years, 11 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

libcgo: initial mingw port work - builds but untested

Patch Set 1 #

Patch Set 2 : code review 812041: libcgo: initial mingw port work - builds but untested #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -2 lines)			Patch
M	src/libcgo/386.S	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/libcgo/Makefile	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/libcgo/amd64.S	View		1 chunk	+1 line, -1 line	0 comments	Download
A	src/libcgo/mingw_386.c	View		1 chunk	+45 lines, -0 lines	0 comments	Download
A	src/libcgo/mingw_amd64.c	View	1	1 chunk	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Joe Poirier

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-03-28 22:32:57 UTC) #1

rsc

14 years, 12 months ago (2010-04-06 06:44:07 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=8e71a381c9ed ***

libcgo: initial mingw port work - builds but untested

R=rsc
CC=golang-dev
http://codereview.appspot.com/812041

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages