Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(989)

Issue 810043: code review 810043: GNU/Linux sed requires \? rather than ?. Just use * in... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 12 months ago by iant
Modified:
14 years, 11 months ago
Reviewers:
CC:
rsc, r, golang-dev
Visibility:
Public.

Description

GNU/Linux sed requires \? rather than ?. Just use * instead.

Patch Set 1 #

Patch Set 2 : code review 810043: GNU/Linux sed requires \? rather than ?. Just use * in... #

Patch Set 3 : code review 810043: GNU/Linux sed requires \? rather than ?. Just use * in... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/deps.bash View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
iant
Hello golang-dev@googlegroups.com, I'd like you to review this change.
14 years, 12 months ago (2010-04-06 14:30:57 UTC) #1
iant
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 12 months ago (2010-04-06 14:32:38 UTC) #2
r
LGTM
14 years, 12 months ago (2010-04-06 16:19:34 UTC) #3
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=ac065925190e *** GNU/Linux sed requires \? rather than ?. Just use * ...
14 years, 12 months ago (2010-04-06 17:23:25 UTC) #4
r2
On Apr 6, 2010, at 10:23 AM, rsc@golang.org wrote: > *** Submitted as > http://code.google.com/p/go/source/detail?r=ac065925190e ...
14 years, 12 months ago (2010-04-06 17:28:53 UTC) #5
rsc
>> GNU/Linux sed requires \? rather than ?. Just use * instead. > > it's ...
14 years, 12 months ago (2010-04-06 17:30:37 UTC) #6
r2
On Apr 6, 2010, at 10:30 AM, Russ Cox wrote: >>> GNU/Linux sed requires \? ...
14 years, 12 months ago (2010-04-06 17:31:33 UTC) #7
iant
14 years, 11 months ago (2010-04-06 18:43:27 UTC) #8
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b