Issue 8011044: code review 8011044: database/sql: link to driver wiki page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8011044: code review 8011044: database/sql: link to driver wiki page (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by bradfitz

Modified:
12 years ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

database/sql: link to driver wiki page Fixes issue 5127

Patch Set 2 : diff -r 5922a8c0ab67 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5922a8c0ab67 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 5922a8c0ab67 https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/pkg/database/sql/sql.go	View	1 2 3	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2013-03-25 23:54:50 UTC) #1

adg

LGTM https://codereview.appspot.com/8011044/diff/5001/src/pkg/database/sql/sql.go File src/pkg/database/sql/sql.go (right): https://codereview.appspot.com/8011044/diff/5001/src/pkg/database/sql/sql.go#newcode8 src/pkg/database/sql/sql.go:8: // The sql package requires a database-specific driver, ...

12 years ago (2013-03-26 00:15:30 UTC) #2

bradfitz

12 years ago (2013-03-26 00:39:00 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=73e94fe4f377 ***

database/sql: link to driver wiki page

Fixes issue 5127

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/8011044

Expand All Messages | Collapse All Messages