Issue 80110043: code review 80110043: net/http: disable recently-introduced flaky test on Windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 80110043: code review 80110043: net/http: disable recently-introduced flaky test on Windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by bradfitz

Modified:
10 years, 1 month ago

Reviewers:
brainman

CC:
adg, brainman, golang-codereviews

Visibility:
Public.

Description

net/http: disable recently-introduced flaky test on Windows Disable it until it's debugged so it doesn't hide other real problems on Windows. The test was known to be unreliable anyway (which is why it only needed 1 of 20 runs to pass), but apparently it never passes on Windows. Figure out why later. Update Issue 7634

Patch Set 1 #

Patch Set 2 : diff -r ec2ac2c466aa https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ec2ac2c466aa https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6815c401f8a1 https://go.googlecode.com/hg/ #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/pkg/net/http/transport_test.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 1 month ago (2014-03-25 22:01:39 UTC) #1

bradfitz

10 years, 1 month ago (2014-03-25 22:20:02 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=a70aa2f24d10 ***

net/http: disable recently-introduced flaky test on Windows

Disable it until it's debugged so it doesn't hide other real
problems on Windows. The test was known to be unreliable
anyway (which is why it only needed 1 of 20 runs to pass), but
apparently it never passes on Windows. Figure out why later.

Update Issue 7634

LGTM=alex.brainman
R=adg, alex.brainman
CC=golang-codereviews
https://codereview.appspot.com/80110043

Expand All Messages | Collapse All Messages